New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci/cibuild.sh: upgrade esptool to 4.5.1 #9016
Conversation
Signed-off-by: chao an <anchao@xiaomi.com>
This PR will fix the ci break when building esp32c6-devkit/coremark: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice find. This newest version of esptool
is required by ESP32-C6 and H2. It was an oversight when adding support for these SoCs.
Its weird that it only began breaking yesterday 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It appears that the error still occurs. Does the CI have any kind of cache that needs to be purged ?
====================================================================================
Configuration/Tool: esp32c6-devkit/coremark
------------------------------------------------------------------------------------
Cleaning...
Configuring...
Building NuttX...
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
100 475k 0 475k 0 0 2122k 0 --:--:-- --:--:-- --:--:-- 2122k
make: *** [tools/Unix.mk:527: nuttx] Error 2
make: Target 'all' not remade because of errors.
Normalize esp32c6-devkit/coremark
I think we need to merge this PR. At least I can build the failing configuration with |
Seems like it didn't help :( |
emm... strange, there should be a issue with the python tool used in esptool |
Post build fail message:
|
But I can build the same configuration on MAC without any issues. I'm still missing the gap here. |
I can also build it locally without any issues on Linux.
|
The major difference in logs is |
@anchao maybe CI has more cores and the issue is hidden in parallel build? Do we know what is |
I also used parallel build on a 12 core/16 threads CPU and it worked fine. Idk if this is the problem. Maybe if |
@pkarashchenko According to the team that works on
|
see the discussion here: apache#9016 Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
Summary
ci/cibuild.sh: upgrade esptool to 4.5.1
Impact
N/A
Testing
ci check