xtensa/esp32: ESP32 not use IMEM in user heap mode #9020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donghengqaz
force-pushed
the
feature/esp32_not_use_imem_in_user_heap_mode
branch
2 times, most recently
from
01cc504
to
6456d5f
Compare
|
@donghengqaz Please fill the required sections in the PR description. |
|
Please rebase to fix the CI |
donghengqaz
force-pushed
the
feature/esp32_not_use_imem_in_user_heap_mode
branch
from
6456d5f
to
c9a202d
Compare
OK, it's passed. |
donghengqaz
force-pushed
the
feature/esp32_not_use_imem_in_user_heap_mode
branch
from
c9a202d
to
c49bec7
Compare
donghengqaz
force-pushed
the
feature/esp32_not_use_imem_in_user_heap_mode
branch
from
c49bec7
to
231c923
Compare
gustavonihei
approved these changes
Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When users enable
Separated userspace heap(ESP32_SPIRAM_USER_HEAP), system don't enable separated heap region of SRAM (ESP32_IMM_HEAP -> XTENSA_IMEM_USE_SEPARATE_HEAP), so that users can have a full larger block of heap.If users still enable
Additional region to kernel heap(ESP32_SPIRAM_COMMON_HEAP), system enable separated heap region of SRAM (ESP32_IMM_HEAP -> XTENSA_IMEM_USE_SEPARATE_HEAP), so that kernel driver can allocate heap from SRAM.Impact
Testing