l2cc: Don't repeat disabling the cache when the cache is already disabled #9048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zyfeier please rebase your change. |
…abled When l2cc is already in disable state, performing a disable operation again will flush incorrect cache data to memory Signed-off-by: zhangyuan21 <zhangyuan21@xiaomi.com>
@zyfeier |
Yes, test with sabre-6quad board and bes2003 board. |
masayuki2009
approved these changes
Apr 25, 2023
xiaoxiang781216
approved these changes
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When l2cc is already in disable state, performing a disable operation again will flush incorrect cache data to memory.
So, when it is found that the L2 cache is in a disabled state during startup, no flash operation is performed. Only when it is necessary to disable the L2 cache, a flush operation is performed.
Impact
L2 cache
Testing
sabre-6quad:smp