Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

esp32: enable LIBC_ARCH_ATOMIC #9078

Merged
merged 1 commit into from Apr 24, 2023
Merged

Conversation

yamt
Copy link
Contributor

@yamt yamt commented Apr 23, 2023

Summary

fixes a build issue in apache/nuttx-apps#1723

Impact

Testing

build tested

@xiaoxiang781216 xiaoxiang781216 merged commit 0066bf8 into apache:master Apr 24, 2023
26 checks passed
@gustavonihei
Copy link
Contributor

gustavonihei commented Apr 24, 2023

@yamt Could you please explain about the need for this patch?

ESP32's toolchain does implement the atomic builtins from GCC, so as long as the atomic operation does not include big numbers, this patch shouldn't be necessary.
Furthermore, this patch will impose performance overhead due to the use of OS-assisted locking via critical sections instead of the conditional load/store instructions from the Xtensa ISA.

@jerpelea jerpelea added this to To-Add in Release Notes - 12.2.0 Jun 13, 2023
@jerpelea jerpelea moved this from To-Add to In Progress in Release Notes - 12.2.0 Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants