New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools/refresh.sh: Add option to refresh all archs or all chips #9231
Conversation
@xiaoxiang781216 why the CI is failing? There are many "deattached" messages, also this LVGL warning:
|
CI failure isn't related to the above message. The problem is that chipkit-wifire trigger the wrong action:
|
@xiaoxiang781216 could you please merge? I restarted the CI more than 5 times already and never fixed the issue! Also already did rebase, etc |
your patch has combability issue, why retrigger ci again before you fix the problem? |
@xiaoxiang781216 could you please point me where is the compatibility issue? Please look the patch, it is not change any existing functionality, and the PR passed in all test, except one that is related to some toolchain fails in the CI. |
Ok, I found the issue, I was comparing:
Instead of:
So, then the refresh.sh was used to normallize "chipkit-wifire/nsh" it was assuming that user want to normalize all chips |
should we use <all-chip|all-board>, <chips|boards> or [all/all|all/all/all]? The end space is very hard to use. |
There is not end space @xiaoxiang781216, the tested space is because we need to inform the "chip name" or the "arch name". Please see the examples:
and
|
arch:renesas or arch/renesas may algin with sim:adb better? |
Currently when we modify some Kconfig related to some chip or some architecture we need to run refresh.sh to all boards that is too slow (more than one hour to finish). This patch modify the script to update only the boards configs of an specific chip or only the boards of an specific architecture. Examples: $ ./tools/refresh.sh --silent --defaults arch:renesas Normalize us7032evb1/ostest Normalize us7032evb1/nsh Normalize skp16c26/ostest Normalize rx65n-rsk2mb/netnsh Normalize rx65n-rsk2mb/ipv6 Normalize rx65n-rsk2mb/nsh Normalize rx65n-rsk1mb/netnsh Normalize rx65n-rsk1mb/nsh Normalize rx65n-grrose/netnsh Normalize rx65n-grrose/ipv6 Normalize rx65n-grrose/nsh Normalize rx65n/nsh It updates the boards from all 'renesas' architecture (m9c, rx65n, sh1) $ ./tools/refresh.sh --silent --defaults chip:rx65n Normalize rx65n-rsk2mb/netnsh Normalize rx65n-rsk2mb/ipv6 Normalize rx65n-rsk2mb/nsh Normalize rx65n-rsk1mb/netnsh Normalize rx65n-rsk1mb/nsh Normalize rx65n-grrose/netnsh Normalize rx65n-grrose/ipv6 Normalize rx65n-grrose/nsh Normalize rx65n/nsh It updates all the boards from renesas chip 'rx65n' family
@xiaoxiang781216 done! |
Summary
Currently when we modify some Kconfig related to some chip or some architecture we need to run refresh.sh to all boards that is too slow (more than one hour to finish).
This patch modify the script to update only the boards configs of an specific chip or only the boards of an specific architecture.
Examples:
$ ./tools/refresh.sh --silent --defaults arch renesas
Normalize us7032evb1/ostest
Normalize us7032evb1/nsh
Normalize skp16c26/ostest
Normalize rx65n-rsk2mb/netnsh
Normalize rx65n-rsk2mb/ipv6
Normalize rx65n-rsk2mb/nsh
Normalize rx65n-rsk1mb/netnsh
Normalize rx65n-rsk1mb/nsh
Normalize rx65n-grrose/netnsh
Normalize rx65n-grrose/ipv6
Normalize rx65n-grrose/nsh
Normalize rx65n/nsh
It updates the boards from all 'renesas' architecture (m9c, rx65n, sh1)
$ ./tools/refresh.sh --silent --defaults chip rx65n
Normalize rx65n-rsk2mb/netnsh
Normalize rx65n-rsk2mb/ipv6
Normalize rx65n-rsk2mb/nsh
Normalize rx65n-rsk1mb/netnsh
Normalize rx65n-rsk1mb/nsh
Normalize rx65n-grrose/netnsh
Normalize rx65n-grrose/ipv6
Normalize rx65n-grrose/nsh
Normalize rx65n/nsh
It updates all the boards from renesas chip 'rx65n' family
Impact
Now we don't need to wait hours the get update done for some board architecture or board chip family.
Testing
Basic test using sim, and other boards