Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools/nuttx-gdbinit/armv7-a: add fpu support #9234

Merged
merged 1 commit into from May 16, 2023

Conversation

anchao
Copy link
Contributor

@anchao anchao commented May 10, 2023

Summary

tools/nuttx-gdbinit/armv7-a: add fpu support

The offset of the relevant registers in xcp will change after
enabling the FPU, this PR will add fpu offset correct the register offset

Signed-off-by: chao an anchao@xiaomi.com

Impact

N/A

Testing

sabre-6quad:nsh

Copy link
Contributor

@jerpelea jerpelea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a commit message describing the change

@acassis
Copy link
Contributor

acassis commented May 10, 2023

@anchao will it work even when FPU support is not enabled in the menuconfig?

The offset of the relevant registers in xcp will change after
enabling the FPU, this PR will add fpu offset correct the register offset

Signed-off-by: chao an <anchao@xiaomi.com>
@anchao
Copy link
Contributor Author

anchao commented May 16, 2023

please add a commit message describing the change

Done

@anchao
Copy link
Contributor Author

anchao commented May 16, 2023

@anchao will it work even when FPU support is not enabled in the menuconfig?

Yes this PR works as expected with or without the FPU

@xiaoxiang781216 xiaoxiang781216 merged commit 26361ee into apache:master May 16, 2023
26 checks passed
@jerpelea jerpelea added this to To-Add in Release Notes - 12.2.0 Jun 13, 2023
@jerpelea jerpelea moved this from To-Add to In Progress in Release Notes - 12.2.0 Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants