net: Add the check that socket domain is equal to bound address type, when do bind. #9295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acassis
reviewed
May 16, 2023
… when do bind. When do socket bind, if the connection domain is not equal to the bound address type, this will cause the stack-buffer-overflow. Signed-off-by: liqinhui <liqinhui@xiaomi.com>
liqinhuixm
force-pushed
the
br_udp_tcp_bind
branch
from
5d0135c
to
6b7caa7
Compare
pkarashchenko
approved these changes
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When bind the sockaddr, Check conn->domain and addr->sa_family. If they aren't equal, return an error early.
which can avoid the problem of stack buffer overflow.
Impact
Avoid an exception caused by using the bad address on binding.
Testing
When the socket of type AF_INET4, if the sockaddr of type AF_INET6 are used, the bind interface returns an error and does not cause any other exception.