net/tcp: Add flag for tcp_close to avoid double free #9414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: When tcp_close_work starts to run in LPWORK, if another event comes and calls tcp_free before tcp_close_work takes net_lock, the tcp_free will be called twice and cause double free. Signed-off-by: Zhe Weng <wengzhe@xiaomi.com>
anchao
approved these changes
May 29, 2023
jerpelea
approved these changes
May 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem:
When
tcp_close_workstarts to run in LPWORK, if another event comes and callstcp_freebeforetcp_close_worktakesnet_lock, thetcp_freewill be called twice and cause double free.Impact
Testing