net: Fix task block when devif_send fails. #9423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjpanag
force-pushed
the
udp_sem
branch
2 times, most recently
from
bd51664
to
217f00b
Compare
When a task needs to send data, a callback is allocated and the transmission is happening in a worker task through devif_send. Synchronization between the two tasks (sender & worker) is achieved by a semaphore. If devif_send fails, this semaphore was never posted, leaving the sending task blocked indefinitely. This commit fixes this by checking the return code of netif_send, and posting this semaphore in case of failure. Polling then stops, and execution is resumed on the sending task.
fjpanag
changed the title
xiaoxiang781216
approved these changes
Jun 1, 2023
xiaoxiang781216
approved these changes
Jun 1, 2023
xiaoxiang781216
approved these changes
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When a task needs to send data, a callback is allocated and the transmission is happening in a worker task through
devif_send. Synchronization between the two tasks (sender & worker) is achieved by a semaphore.If
devif_sendfails, this semaphore was never posted, leaving the sending task blocked indefinitely. This commit fixes this by checking the return code ofnetif_send, and posting this semaphore in case of failure.Polling then stops, and execution is resumed on the sending task.
Aslo see here.
Impact
Bug fix.
Testing
Tested on a custom target based on STM32F427.
A UDP datagram is sent that it is larger than the network MTU (which will cause
devif_sendto fail).Previously the sending task was blocked, but now it quickly returns with an error.