net/icmp: Save poll device in icmp_poll_s #9483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ICMP's conn->dev is changing in icmp_sendmsg, when sending to different address, or when error occurs (like NETDEV_DOWN). Then the poll callback cannot be dropped from previous dev in free, because the dev is wrong. So add dev to struct icmp_poll_s just like struct udp_poll_s. Signed-off-by: Zhe Weng <wengzhe@xiaomi.com>
xiaoxiang781216
approved these changes
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ICMP's
conn->devis changing inicmp_sendmsg, when sending to different address, or when error occurs (likeNETDEV_DOWN). Then the poll callback cannot be dropped from previousdevinicmp_callback_free, because thedevis wrong.So add
devtostruct icmp_poll_sjust likestruct udp_poll_s.Impact
Testing
Manually / CI