risc-v/mpfs: add CoreMMC support #9548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * | ||
| ****************************************************************************/ | ||
|
|
||
| static void mpfs_modifyreg8(uintptr_t addr, uint8_t clearbits, |
There was a problem hiding this comment.
Maybe it is time for void modifyreg8(unsigned int addr, uint8_t clearbits, uint8_t setbits) interface placed in arch/risc-v/src/common? I see mpfs_modifyreg8 in arch/risc-v/src/mpfs/mpfs_usb.c that duplicates 95% of this.
There was a problem hiding this comment.
Thanks, fixed all the others but will come back to this, as it'd affect multiple drivers / files.
There was a problem hiding this comment.
Sure. That is more an improvement and should be done in a separate PR.
This adds support for the CoreMMC v3.1 FPGA driver as described in Microchip Handbook HB0510. The driver doesn't support DMA. Signed-off-by: Eero Nurkkala <eero.nurkkala@offcode.fi>
pkarashchenko
approved these changes
Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for the CoreMMC v3.1 FPGA driver as described in Microchip Handbook HB0510. The driver doesn't support DMA.
Summary
This adds the driver for CoreMMC FPGA block. This may be added to the Polarfire or related FPGA.
Impact
Testing
Hardware with the CoreMMC IP configured properly. FAT32 file system testing with file access (read / writes / copying / appending files).