libs/libc/locale/langinfo: implement the nl_langinfo function #9662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. the nl_langinfo can help to pass the ltp/open_posix_testsuite/strftime testcases 2. the implementation are referred to https://pubs.opengroup.org/onlinepubs/9699919799/functions/nl_langinfo.html Signed-off-by: guoshichao <guoshichao@xiaomi.com>
xiaoxiang781216
approved these changes
Jul 2, 2023
xiaoxiang781216
approved these changes
Jul 2, 2023
Comment on lines
+152
to
+163
| case ERA: | ||
| return ""; | ||
| case ERA_D_FMT: | ||
| return ""; | ||
| case ALT_DIGITS: | ||
| return ""; | ||
| case ERA_D_T_FMT: | ||
| return ""; | ||
| case ERA_T_FMT: | ||
| return ""; | ||
| case CRNCYSTR: | ||
| return ""; |
There was a problem hiding this comment.
I would recommend it to
Suggested change
| case ERA: | |
| return ""; | |
| case ERA_D_FMT: | |
| return ""; | |
| case ALT_DIGITS: | |
| return ""; | |
| case ERA_D_T_FMT: | |
| return ""; | |
| case ERA_T_FMT: | |
| return ""; | |
| case CRNCYSTR: | |
| return ""; | |
| case ERA: | |
| case ERA_D_FMT: | |
| case ALT_DIGITS: | |
| case ERA_D_T_FMT: | |
| case ERA_T_FMT: | |
| case CRNCYSTR: | |
| default: | |
| break; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Impact
Testing