net: add netfilter compatible definitions for iptables #9744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaoxiang781216
approved these changes
Jul 8, 2023
acassis
approved these changes
Jul 8, 2023
acassis
reviewed
Jul 8, 2023
|
|
||
| uint16_t proto; | ||
|
|
||
| /* TOS to match iff flags & IP6T_F_TOS */ |
There was a problem hiding this comment.
I think it should be if, The libip6tc.c file contains the following code:
if (e->ipv6..flags & IP6T_F_TOS)
printf("TOS: %u\n", e->ipv6.tos);
or
if (e->ipv6.flags & IP6T_F_TOS)
printf("%s-? %d ",
e->ipv6.invflags & IP6T_INV_TOS ? "! " : "",
e->ipv6.tos);
type of e->ipv6 is this struct ip6t_ip6.
There was a problem hiding this comment.
@zhhyu7 I just got this same comment in the Linux kernel source. Linux kernel uses GPL license that is not compatible with Apache. Be careful to not copy code from Linux (we want to continue to be Linux-like, not a Linux license infractor). That said, in theory header files symbols are not subject to GPL according to RMS: https://linux.slashdot.org/story/11/03/20/1529238/rms-on-header-files-and-derivative-works
But never, ever, ever, look the Linux kernel source code and write a NuttX source code, otherwise you are creating derivative code :-).
In order to support the compilation of third-party library, we encounter some situations where the macro is not defined, refer to the common implementation of other systems and add relevant definitions. Signed-off-by: zhanghongyu <zhanghongyu@xiaomi.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In order to support the compilation of third-party library, we encounter some situations where the macro is not defined, refer to the common implementation of other systems and add relevant definitions.
Impact
Testing
sim:local