driver/audio: low level reset must always succeed #9846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- considering simplicity and design assumption, the reset function must work without flaw. If it fails, there is no way to recover but to reset again. so checking return status does not bring additional benefit - There is unnecessary switch inside switch which is making code not too readable Signed-off-by: mks2183 <manishsharma3134@gmail.com>
|
Hi @xiaoxiang781216 Sir, Could you please review it again ? Regards, |
|
Hi Sir @acassis / @xiaoxiang781216 , My build is failed due to macOS. If this is unrelated then Could you please merge this? Regards, |
jerpelea
approved these changes
Jul 18, 2023
|
Thanks Sir @jerpelea for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
considering simplicity and design assumption, the reset function must work without flaw. If it fails, there is no
way to recover but to reset again so checking return status does not bring additional benefit.
There is unnecessary switch inside switch which is making code not too readable
Impact
Testing