Updated ind geo data as per 2020-11-24 notification #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks, Akash for report and Anushi for patch.
…eceiveInventoryProduct service to avoid the ClassCastException. Also corrected loop condition while creating inventory information during PO receiving to fix the issue where each product is getting received two times (doubled the qty) instead of single time.(OFBIZ-11909) (apache#218)
…framework component. Also done formatting changes as per checkstyle best practices. (OFBIZ-11904)
…applications component. Also done formatting changes as per checkstyle best practices. (OFBIZ-11904)
…FBIZ-11487) Thanks: Sourabh Punyani
Thanks, Akash for report and Anushi for the Patch.
…StateList (OFBIZ-11838)
On orderview screen at the ordermgr, when a user tries to change the status of
the order, in OrderInfo.ftl, we are calling "changeOrderStatus" request as
<@ofbizUrl>changeOrderStatus/orderview</@ofbizUrl>
Hence when the request is done, it is rewriting URL to
https://localhost:8443/ordermgr/control/changeOrderStatus/orderview.
When js functions running in the backend like "getAssociatedStateList" are
called, they are getting the wrong URL to send a request to. This was causing
the issue.
For now, there are two different fixes that can handle both problems which are
mentioned in OFBIZ-2562 and OFBIZ-11838.
1.
To change the request mapping for "changeOrderStatus" and add request-redirect
to "orderview" screen. Change the actions in the forms in OrderInfo.ftl to
call "changeOrderStatus" request only and then remove code in
"getAssociatedStateList" js function to rewrite URL.
2.
To add .length to the existing URL rewrite code written in
"getAssociatedStateList" js function as
if (jQuery('#orderViewed').length) {
requestToSend = "/ordermgr/control/getAssociatedStateList"
}
Thanks: Pritam Kute!
I picked the 2nd solution
When creating event for the party other than the loggedin user, the party should be in CAL_OWNER role to be added to event. Added appropriate check in service along with the error message. Thanks Rubia Elza Joshep for reporting the issue and Aditi Patidar for providing the patch
…y DSL (OFBIZ-11487)" This reverts commit faa59b3. It introduced 3 errors in testIntegration, in: testGlPostingOnCancelCheckRun testGlPostingsOnVoidPayment testVoidPayment
The tests failed because CAL_OWNER instead of CONTACT was necessary
The order created with test case testCreateOrderServiceProduct did not get approved so the quick ship process did not work correctly while with specific configurableServiceOrder-test new order has got approved and the quick ship process worked correctly. We got multiple payment methods i.e. EXT_PAYPAL and EXT_COD but in the test case only EXT_COD was defined. Without shopping cart tests testIntegration works perfectly. Shopping cart has multiple payment methods, and as cart has multiple payment methods, order is not approved (org/apache/ofbiz/order/shoppingcart/CheckOutHelper.java:1166) This ensures single paymentMethod. It could reviewed again when converting ShoppingCartTests.xml to Groovy. I have added a comment about that Thanks: Pawan and Suraj
… bug. This fixes it and clarifies things by using className instead of module in code when used as a var not as the MODULE const.
…tion component, also fixed some case indentation checkstyle issues. (OFBIZ-11922)
…rk component, also fixed some case indentation checkstyle issues. (OFBIZ-11922)
… to data resource (OFBIZ-10834) Changes made in startsWith and indexOf methods in ContentManagementServices for OFBIZ-9254 where wrong (reversed). Fortunately only place where this happened. I added a comment to make clear why we have 2 empty else if I'll backport later, conflicts to handle by hand... Thanks: Ankush Upadhyay for spotting the bug
Fixes some new warnings coming from JUnit 4.13, a step ahead to JUnit 5. I left 2 complicated ExpectedException warnings. Change will be needed for JUnit 5. https://www.luxoft-training.com/news/migrating-from-junit-4-to-junit-5-replacing-rules-with-the-extension-model-part-1/
This can be tested using ./gradlew "ofbiz --test component=product --test suitename=producttagtests" Thanks: Akash Jain for report, Anushi Gupta for the patch
There are some inconsistencies in the code for string comparison statusId.equals(PRUN_COMPLETED) whereas it should be written as PRUN_COMPLETED.equals(statusId) cause the former can throw NullPointerException if the variable found to be NULL. Thanks: Devanshu for your contribution.
…ovy(OFBIZ-11877) Thanks, Jacques for the review.
…(OFBIZ-11907) (apache#221) * Improved: WidgetWorker should not write generated html to Appendable (OFBIZ-11907) Refactoring of WidgetWorker so that it generates URI and JSoup Element objects to represent created URLs, hidden forms and anchor tags. This replaces the previous approach where WidgetWorker would write string representations of the URLS, hidden forms and anchor tags directly to an Appendable object passed to it. Callers to WidgetWorker have been modified to render the new objects created by WidgetWorker to their relevant I/O. * Improved: Handle spaces in link targets when building URIs (OFBIZ-11907) Corrected handling of spaces in target values passed to WidgetWorker when bulding URIs. Spaces are URL encoded as %20.
…e issues in framework component. Also fixed some extra spaces and naming conventions related checkstyle issues. (OFBIZ-11921)
…e issues in applications component. Also fixed some extra spaces and naming conventions related checkstyle issues. (OFBIZ-11921)
(OFBIZ-11587) Add <set field=helpAnchor... in CommonScreens for application where it's not present. With this commit all OFBiz application help go to the html generated from asciidoc files
Better usability when clicking on named border
Form getJs link according to SEO Config setting
Some named borders were hidden in ecomseo landing page
…-11986) While researched on ticket OFBIZ-11896 identified that groovy version of createPartyGroupRoleAndContactMechs service (converted from mini lang at rev 8af7cf8 ) is not working. Identify these two reasons, resolvePartyGroupMap called incorrectly resolvePostalAddressMap and resolveTelecomNumberMap implemented incorrectly as 'postalAddress' and 'telecomNumber' map processor not available into PartyMapProcs.xml. There may be more reasons along with these two reasons. Thanks: Akash Jain for report, Sourabh Jain for incomplete patch (missed 2nd point from Akash
…een is not working (OFBIZ-7343) Long ago I spotted an issue: <<In French I got this js error message in console (else nothing apears anywhere) SyntaxError: missing ) after argument list ...=9000&partyId=Company', 'Adresse d'expédition - Géolocalisation', '450', '550') It's due to the quote in "Adresse d'expédition" We could though commit by escaping the popUptitle, but I also think we should change from the popup (and everywhere the same is used) to a modal layered window.>> Turned out that: <<I had a quick look to see if we could not use a modal layer instead of a popup, but it's not obvious to use modal layer from Freemarker. This does not mean that it can't be done... I'll see later...>> Here is a late workaround :)
…-11986) As Akash Jain reported: <<While researched on ticket OFBIZ-11896 identified that groovy version of createPartyGroupRoleAndContactMechs service (converted from mini lang at rev 8af7cf8 ) is not working. Identify these two reasons, resolvePartyGroupMap called incorrectly resolvePostalAddressMap and resolveTelecomNumberMap implemented incorrectly as 'postalAddress' and 'telecomNumber' map processor not available into PartyMapProcs.xml. There may be more reasons along with these two reasons.>> He was so true to say the later! There are also some intentionally or automated formattings. Thanks: Akash for report, Sourabh Jain for shy tentative :)
AsciiDoc files (OFBIZ-11893) * Add allow-uri-read when generated html and pdf to be able to allow image from external uri, it's used for apache2.0 image; Generalize usage of apache2.0 image for all main documents * Put Trunk Version in gradle generation parameter and so remove in all documents (to avoid Version unspecified)
AsciiDoc files (OFBIZ-11893) Add the correct set when use icon, to avoid INFO message
Not able to open source file when clicking on named border in ecomseo landing page Thanks Jacques for reporting
…FBIZ-12031) Help to remove dependency of product component from widget component An afterthought: webapp component seems better for SeoConfigUtil.java than widget component. Thanks Jacques for review
…IZ-12035)
* modification in gradle generateOfbizDocumentation task to copy the
image/${components.name} subdirectory in the general
docs/asciidoc/images/ directory before generation
and remove it after.
* correction in generateAllPluginsDocumentation to put copy of OFBiz-Logo in doFirst to avoid it's run during gradle Configure project
…Doc files (OFBIZ-11893) sy-impersonation.adoc minor correction, * imagesDir cannot be out of asciidoc directory because content of it s copied in build directory when document is generated * internal link to go to sub-section security was wrong because securty automatic anchor is generate for general security chapter
Comment + Rename method
… to 255 char (OFBIZ-12021) "Description" and "comment" fields are restricted to 255 char. However after some research I found that all the supported databases support longer then 255 char I would expect users to want to write more then 255 char in a comment (I know I personally can). A discussion has been started on dev ML: https://markmail.org/message/7utrgejc2c44i37u Also adds a note in DATAMODEL_CHANGES.adoc Thanks: ddev
Fix named border not properly clean up.
… to 255 char (OFBIZ-12021) This reverts commit 686f01c. We have test integration issues to fix
… to 255 char (OFBIZ-12021) This reverts commit 686f01c. We have test integration issues to fix
… to 255 char (OFBIZ-12021) This reverts commit 8736162. We have test integration issues to fix Due to TortoiseGIt, something weird happened, confused me to revert the revert :/
…nts (OFBIZ-12035) I'm not sure in which circumstances but I still find some files in /docs/asciidoc/images/ It's not a big deal but showing in Git when committing Better prevent that so I ignore the dir by putting it in .gitignore
Now OFBiz-Logo is printed in pdf
The variant products' images are being saved in the variable IMG encoded as urls, thus selecting the variant triggers an image override with an unsuitable file name. Thanks: Alex Bodnaru
…-11986) Service is used for create employee service, and email address is not mandatory, so emailAddressContext should be empty if parameters.emailAddress is empty. Correction done is to call createPerson before creating emailAddressContext to be able to put set partyId in the if not empty parameters.emailAddress
Allow the opening of screen definition that contributed to the web page from the browser. Command to open the file is set at widget.dev.cmd.openSourceFile. Thanks Jacques for review.
Sync with upstream
- Deletion of Union territory IN-DD, IN-DN; - Addition of Union territory IN-DH; - Correction of spelling for IN-AR, IN-BR, IN-CH, IN-CT, IN-DH, IN-GJ, IN-HP, IN-HR, IN-JH, IN-JK, IN-KA, IN-LA, IN-MH, IN-ML, IN-NL, IN-RJ, IN-TG, IN-TN, IN-UT;
dixitdeepak
deleted the
OFBIZ-12067-update-IND-geo-data-as-per-2020-11-24-notification
branch
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved:Updated ind geo data as per 2020 11 24 notification
(OFBIZ-12067)
Explanation