Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: Link Party feature stop the EECA rules globally(OFBIZ-12424) #373

Closed
wants to merge 0 commits into from

Conversation

rohitkou
Copy link
Contributor

@rohitkou rohitkou commented Dec 1, 2021

Fixed: Link Party feature stop the EECA rules globally(OFBIZ-12424)

Create and use the default-no-eca delegator instead of setting EntityEcaHandler object null on delegator.

@sonarcloud
Copy link

sonarcloud bot commented Dec 1, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@JacquesLeRoux JacquesLeRoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Rohit,

That sounds indeed like the right thing to do to me

@mbrohl
Copy link
Contributor

mbrohl commented Feb 3, 2023

@rohitkou can you please remove the merge commit from the PR and possibly do a rebase instead?
Thanks!

@JacquesLeRoux
Copy link
Contributor

Else, as it's a very simple change we can also do it manually and backport...

@rohitkou
Copy link
Contributor Author

rohitkou commented Feb 4, 2023

Thanks you @JacquesLeRoux and @mbrohl, I've extracted the changes into a patch file and added it to ticket OFBIZ-12424. We can close this pull request now.

@sonarcloud
Copy link

sonarcloud bot commented Feb 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants