Improved: Move edit of invoice header to InvoiceSubTabBar (OFBIZ-12440) #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In general, a <object>TabBar menu is intended to give users access to overview related to the <object>. And a <object>SubTabBar menu is intended to give users to actions to be performed on the <object>, like status changes, adding new records, etc. The menu-item for editing the invoice header (aptly translated as 'Header') is currently located in the InvoiceTabBar menu in AccountingMenus.xml. Given that this menu-item is intended for users with UPDATE permissions and to give those users access to a screen to edit the data, this menu-item must move to the InvoiceSubTabBar menu Modified: AccountingMenus.xml - moved 'edit' menu-item for invoice from InvoiceTabBar menu to InvoiceSubTabBar menu. adjusted label.
PierreSmits
changed the title
|
Kudos, SonarCloud Quality Gate passed!
|
PierreSmits
added a commit
to PierreSmits/ofbiz
that referenced
this pull request
Jan 10, 2022
* trunk: (80 commits) Improved: makes a French label consistent on the page Improved: Move edit of invoice header to InvoiceSubTabBar (OFBIZ012440) (apache#409) Improved: Have a Menu in Catalog featuring actions to create the main objects (OFBIZ-11774) (apache#433) Fixed: Store Group screen don't connect with grids (OFBIZ-12481) (apache#435) Improved: List and Grid (OFBIZ-11345) (apache#434) Improved: Use gradlew npm_outdated gradle-node-plugin taks to check outdated scripts (OFBIZ-12480) Improved: Use NPM with gradle to get external JS dependencies (OFBIZ-11960) Improved: List and Grid (OFBIZ-11345) (apache#432) Improved: List and Grid (OFBIZ-11345) (apache#431) Improved: VIEW permissions FinAccount mutations (OFBIZ-12451) (apache#410) Improved: Replace ELRTE plugin with Trumbowyg (OFBIZ-10093) (apache#425) Improved: Remove unused labels from AccountingUiLabels.xml (OFBIZ-9352) (apache#413) Improved: VIEW permissions BillingAccount (OFBIZ-12457) (apache#414) Improved: Invoice - CommonInvoiceDecorator (OFBIZ-12458) (apache#415) Improved: Agreement - CommonAgreementDecorator (OFBIZ-12462) (apache#418) Improved: List and Grid (OFBIZ-11345) (apache#426) Improved: Have a menu in Marketing featuring actions to create main objects (OFBIZ-11783) (apache#428) Improved: Have a Menu in Humanres featuring actions to create the main objects (OFBIZ-11777) (apache#429) Improved: Dutch translations (OFBIZ-10363) (apache#430) Documented: Gradle Wrapper is not downloaded with 18.12.03 (OFBIZ-12471) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In general, a TabBar menu is intended to give users access to overview related to the . And a SubTabBar menu is intended to give users to actions to be performed on the , like status changes, adding new records, etc.
The menu-item for editing the invoice header (aptly translated as 'Header') is currently located in the InvoiceTabBar menu in AccountingMenus.xml.
Given that this menu-item is intended for users with UPDATE permissions and to give those users access to a screen to edit the data, this menu-item must move to the InvoiceSubTabBar menu
Modified: AccountingMenus.xml