Improved: Tax Authority Find (OFBIZ-12521) #472
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, a user with only 'VIEW' permissions, as demonstrated in trunk demo with userId = auditor, accessing the Agreement Roles screen, sees editable fields and/or triggers (to requests) reserved for users with 'CREATE' or 'UPDATE' permissions. To see/test: https://localhost:8443/accounting/control/EditAgreementRoles?agreementId=8000 modified: - AgreementScreens.xml - restructured screen EditAgreementRoles to work with permissions - AgreementForms.xml - added grid AgreementRoles for users with VIEW permissions additional cleanup
Currently the Find Tax Authority screen shows a paginated overview of tax authorities without any filter capabilities. modified: - TaxAuthorityScreens.xml added elements for search and find capabilities - TaxAuthorityForms.xml added form for filtering tax authorities enhanced grid regarding found tax authorities to work with search/find functionality
PierreSmits
changed the title
Missed essential changes for showing tax authorities when screen is accessed for first time
|
Kudos, SonarCloud Quality Gate passed!
|
|
Closing as undesired changes were included in the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved: Tax Authority Find (OFBIZ-12521)
Currently the Find Tax Authority screen shows a paginated overview of tax authorities without any filter capabilities.
modified:
added elements for search and find capabilities
added form for filtering tax authorities
enhanced grid regarding found tax authorities to work with search/find functionality