Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improved: have profileMenuLocation (OFBIZ-12981) #749

Merged
merged 3 commits into from
Apr 12, 2024

Conversation

PierreSmits
Copy link
Member

Profile screens are used in various components as portalpageportlets, and have references to various party menus. As menus in the various profile screens are parameterized to use ${parameters.mainMenuLocation} this generates errors in the components/applications where these screens are used as portal page elements.

Having a context-param profileMenuLocation resolves this issue.

modified:
partty - web.xml: have context-param profileMenuLocation
party - ProfileScreens.xml: change location profile menus various screens

Given that request screens are used as portal pages, the inclusion of such portal pages in other applications leads to errors being thrown for the associated menus (due to the use of the mainMenuLocation parameter in web.xml).
Having a requestMenuLocation in web.xml solves this issue.

modified:
- web.xml: add contextParam requestMenuLocation
- CommonScreens.xml: change location request related menus
- CustRequestScreens.xml: change location request related menu
Profile screens are used in various components as portalpageportlets, and have references to various party menus. As menus in the various profile screens are parameterized to use ${parameters.mainMenuLocation} this generates errors in the components/applications where these screens are used as portal page elements.
Having a context-param profileMenuLocation resolves this issue.

modified:
web.xml: added context-param profileMenuLocation
Profile screens are used in various components as portalpageportlets, and have references to various party menus. As menus in the various profile screens are parameterized to use ${parameters.mainMenuLocation} this generates errors in the components/applications where these screens are used as portal page elements.
Having a context-param profileMenuLocation resolves this issue.

modified:
ProfileScreens.xml: change menu locations
Copy link

sonarcloud bot commented Apr 11, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@mbrohl
Copy link
Contributor

mbrohl commented Apr 11, 2024

We now have mixed changes for order and party and two Jiras together in one PR, this should be splitted.

I also do not understand those changes. The error seems to be introduced by the changes made by you to parametrize the menu location. Now it becomes necessary to make this even more complicated by introducing additional context parameters. The locations for mainMenuLocation and requestMenuLocation are the same, why are they necessary?

@PierreSmits
Copy link
Member Author

The requestMenuLocation was necessary to be implemented due to the fact that request features are incorporated in the projectmgr plugin. Regarding the projectmgr menu parameterisations ticket OFBIZ-12975 has been created.

@JacquesLeRoux JacquesLeRoux merged commit d897eff into apache:trunk Apr 12, 2024
6 checks passed
@PierreSmits PierreSmits deleted the OFBIZ-12981 branch April 12, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants