-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed: PartyTypeAttr correction (OFBIZ-13076) #793
Fixed: PartyTypeAttr correction (OFBIZ-13076) #793
Conversation
Quality Gate passedIssues Measures |
Hi @stschikin , Please provide a description following our description template. 2 reasons here:
|
thanks for your advice. I have edited the original post as requested. |
Hi @stschikin, Why did you remove?
I see no pb with that. |
Ha, I think I know why now, because of
Right? |
The relation to Party seems kind of redundant with the relation to PartyType. I thought I had seen similar relations in other entities of that type, but after rechecking the TypeAttr entities (e.g. AgreementItemTypeAttr, ContactMechTypeAttr, etc), it looks like the deletion of the Party relation was unnecessary. How shall I proceed here? |
Yes, we finally can keep it. A party has only one type, but a party type may have several attributes, hence several relations with a party. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep
<relation type="many" rel-entity-name="Party">
<key-map field-name="partyTypeId"/>
</relation>
After re-evaluating the entire pull request, it looks like I have confused TypeAttr entities with Attribute entities. Attribute entities need a AttrValue, but TypeAttr do not. I found out in Jira OFBIZ-294 that TypeAttr serve as an extension to Type entities and therefore PartyTypeAttr was defined correctly and does not need any fixing... |
Thanks for the clarification @stschikin Please close your PR and the Jira, TIA |
The entity PartyTypeAttr was missing an attrValue field and the description field needed to be renamed to align with other similar entities such as AgreementAttribute, AgreementItemAttribute, ContactMechAttribute, PartyAttribute