Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved: Use GroovyBaseScript's makeValue utility methods in each Groovy files (OFBIZ-11779) #33

Merged
merged 3 commits into from Jun 27, 2020
Merged

Improved: Use GroovyBaseScript's makeValue utility methods in each Groovy files (OFBIZ-11779) #33

merged 3 commits into from Jun 27, 2020

Conversation

priyasharma1
Copy link
Contributor

(OFBIZ-11779)

pwverma
pwverma approved these changes Jun 24, 2020
View reviewed changes
Copy link
Contributor

@pwverma pwverma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good to me, thanks Priya :)

@priyasharma1 @nmalin
Update bi/groovyScripts/DimensionServices.groovy
e5c0b67 
Co-authored-by: Nicolas Malin <nmalin@apache.org>
@sonarcloud
Copy link

sonarcloud bot commented Jun 25, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@pwverma pwverma merged commit d931dfb into apache:trunk Jun 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmalin nmalin nmalin left review comments

@pwverma pwverma pwverma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@priyasharma1 @pwverma @nmalin @priyasharma01