Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: Add To Cart and related UI issue for the products with variant explosion and feature explosion (OFBIZ-11970) #41

Closed
wants to merge 4 commits into from

Conversation

lodhiravi
Copy link

@lodhiravi lodhiravi commented Aug 28, 2020

Done following-

  1. Corrected markup to fix the issue where add to cart is not working for the feature explosion products.
  2. Added a separate screen for rendering Product UOM dropdown and set the last view correctly to avoid ajax view to be used in subsequent request (OFBIZ-11970).'

Issue #2 was due to the ajax request and response view of the additem request. In additem request last saved view or the view of the last request is rendered on successful operation and in this case the last request/view is the one which is used to render UOM dropdown. So set the last view with the last saved view.

…king for the feature explosion products. Added a separate screen for rendering Product UOM dropdown and set the last view correctly to avoid ajax view to be used in subsequent request (OFBIZ-11970).
@sonarcloud
Copy link

sonarcloud bot commented Aug 28, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mbrohl
Copy link
Contributor

mbrohl commented Feb 13, 2021

@lodhiravi Thanks for your appreciated contribution.
Can you explain why we need an additional screen in the ecommerce component? Thanks!

@lodhiravi
Copy link
Author

lodhiravi commented Apr 10, 2021

@mbrohl

Sorry for the late response.

There are two reasons (after my recent push) to introduce a new screen -

  1. To Set the last saved view in the last view to avoid ajax request's view being used in the subsequent requests. Earlier when we select color/size an ajax request to render ProductUomDropDownOnly used and when we select uom and clicks on add to cart, the item gets added but the ProductUomDropDownOnly gets rendered as the last view was to render that.
  2. To improve the drop-down markup using bootstrap in order to make it consistent with other front-end screens.

@lodhiravi lodhiravi closed this Apr 10, 2021
@lodhiravi lodhiravi reopened this Apr 10, 2021
@sonarcloud
Copy link

sonarcloud bot commented Apr 10, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nmalin
Copy link
Contributor

nmalin commented Sep 28, 2021

I loaded from my local,
Thanks all

@nmalin nmalin closed this Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants