Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved: Refactoring groovy folder structure and package declaration (OFBIZ-12813) #86

Conversation

mbrohl
Copy link
Contributor

@mbrohl mbrohl commented Jul 30, 2023

Moves groovy scripts to src and adds a package declaration to all of them.

Work was done using automatic scripts from Wiebke Pätzold.
LoadReactApp.groovy was handled manually because the license header was placed below some import statements.

… (OFBIZ-12813)

Moves groovy scripts to src and adds a package declaration to all of them.

Work was done using automatic scripts from Wiebke Pätzold.
LoadReactApp.groovy was handled manually because the license header was
placed below some import statements.
@mbrohl
Copy link
Contributor Author

mbrohl commented Jul 30, 2023

Needs some more work, should not be merged without changes on:

  • InvoiceAcctgTransEntry.rptdesign
  • birt/webapp/ordermgr/WEB-INF/controller.xml
  • EbayEmailScreens.xml
  • projectmgr TaskScreens.xml contains a ref to a BSH file that should be removed

Michael Brohl added 4 commits July 30, 2023 21:09
CreateApplicationList.groovy (OFBIZ-12813)
The references groovy script was not present anymore which lead to the
untouched reference to groovyScripts.
The referenced groovy script GetEmailOptions.groovy was not present
anymore which lead to the untouched reference to groovyScripts.
@sonarcloud
Copy link

sonarcloud bot commented Jul 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mbrohl mbrohl merged commit 235f24a into apache:trunk Aug 1, 2023
2 checks passed
@mbrohl mbrohl deleted the OFBIZ-12813_Refactor_groovy_folder_structure_and_add_package_declaration branch August 1, 2023 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant