Skip to content
This repository has been archived by the owner on May 9, 2020. It is now read-only.

Commit

Permalink
Fixed: Missing file results in error
Browse files Browse the repository at this point in the history
(OFBIZ-9198)

When accessing a file/image in ecomseo (only seo version) that is physically 
missing or the dataresource attribute isPublic=="N" the request results 
in a loop.

jleroux: to break the loop in case or error, I simply decided to return a 
response of type none. I also added the same for io-error which can be returned
by the DataEvents class, also in ecommerce controller

Thanks: Ingo Wolfmayr for report

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1781662 13f79535-47bb-0310-9956-ffa450edef68
  • Loading branch information
JacquesLeRoux committed Feb 4, 2017
1 parent 0d24121 commit 30013a4
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 0 deletions.
1 change: 1 addition & 0 deletions plugins/ecommerce/webapp/ecommerce/WEB-INF/controller.xml
Expand Up @@ -1837,6 +1837,7 @@ under the License.
<event type="java" path="org.apache.ofbiz.content.data.DataEvents" invoke="serveObjectData"/>
<response name="success" type="none"/>
<response name="error" type="view" value="error"/>
<response name="io-error" type="none"/>
</request-map>

<request-map uri="showShoppingList">
Expand Down
8 changes: 8 additions & 0 deletions plugins/ecommerce/webapp/ecomseo/WEB-INF/controller.xml
Expand Up @@ -27,4 +27,12 @@ under the License.
<description>OFBiz: eCommerce SEO Controller Configuration File</description>

<handler name="jsp" type="view" class="org.apache.ofbiz.ecommerce.webapp.view.JspViewHandler"/>

<request-map uri="stream">
<event type="java" path="org.apache.ofbiz.content.data.DataEvents" invoke="serveObjectData"/>
<response name="success" type="none"/>
<response name="error" type="none"/>
<response name="io-error" type="none"/>
</request-map>

</site-conf>

0 comments on commit 30013a4

Please sign in to comment.