Skip to content
This repository has been archived by the owner on May 9, 2020. It is now read-only.

Commit

Permalink
Fixes: Order By Referrer is not working
Browse files Browse the repository at this point in the history
(OFBIZ-7318)

See
https://ofbiz-vm.apache.org:8443/ordermgr/control/OrderPurchaseReportOptions
Section : Order By Referrer

Found out that in OrderByReferrer.rptdesign we tried to fetch nonexisting fields
like "visitId" and "initialReferrer" from SalesOrderItemFact which causing 
problem in this report. On rev #886743 SalesOrderItemFact extended with visitId 
and initialReferrer and on rev #1055774 these field has been removed.
So I think we need to clean references of visitId and initialReferrer from the 
report and if we removed these fields then report will not make any sense. 
So in my opinion it is better to remove this report from OFBIZ.

Thanks: Rohit Koushalfor report and patch

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1761678 13f79535-47bb-0310-9956-ffa450edef68
  • Loading branch information
JacquesLeRoux committed Sep 21, 2016
1 parent 4fb8bbe commit 782badc
Show file tree
Hide file tree
Showing 6 changed files with 0 additions and 814 deletions.
10 changes: 0 additions & 10 deletions specialpurpose/birt/config/BirtUiLabels.xml
Expand Up @@ -93,11 +93,6 @@
<value xml:lang="fr">Tous les lignes de commandes ayant des codes promotionels</value>
<value xml:lang="zh">所有带有折扣优惠码的订单明细</value>
</property>
<property key="BirtOrderReportAllReferrer">
<value xml:lang="en">All Referrer</value>
<value xml:lang="fr">Tous apporteurs d'affaires</value>
<value xml:lang="zh">所有访问来源</value>
</property>
<property key="BirtOrderReportCouponSalesReport">
<value xml:lang="en">Coupon Sales Report</value>
<value xml:lang="fr">Ventes promotionelles</value>
Expand All @@ -118,11 +113,6 @@
<value xml:lang="fr">Net avant frais généraux</value>
<value xml:lang="zh">计入制造费用前的净值报表</value>
</property>
<property key="BirtOrderReportOrderByReferrer">
<value xml:lang="en">Order By Referrer</value>
<value xml:lang="fr">Commandes par apporteurs d'affaires</value>
<value xml:lang="zh">按访问来源排序</value>
</property>
<property key="BirtOrderReportProductDemandReport">
<value xml:lang="en">Product Demand Report</value>
<value xml:lang="fr">Demandes par produit</value>
Expand Down
8 changes: 0 additions & 8 deletions specialpurpose/birt/data/OrderPortletData.xml
Expand Up @@ -18,14 +18,6 @@
under the License.
-->
<entity-engine-xml>
<PortalPortlet portalPortletId="OrderByReferrer"
portletName="Sale Orders By Referrer Report"
screenName="SaleOrdersByReferrerReport"
screenLocation="component://birt/widget/order/OrderScreens.xml"
description=""/>
<PortletPortletCategory portalPortletId="OrderByReferrer" portletCategoryId="REPORT"/>
<PortalPagePortlet portalPageId="OrderReportPage" portalPortletId="OrderByReferrer" portletSeqId="00001" columnSeqId="00001" sequenceNum="5"/>

<PortalPortlet portalPortletId="OrderByChannel"
portletName="Sale Orders by Channel"
screenName="SaleOrdersByChannelReport"
Expand Down
4 changes: 0 additions & 4 deletions specialpurpose/birt/webapp/ordermgr/WEB-INF/controller.xml
Expand Up @@ -94,9 +94,6 @@ under the License.
<response name="success" type="view" value="ProductDemandOrderReport"/>
</request-map>

<request-map uri="OrderByReferrer.pdf"><security https="true" auth="true"/>
<response name="success" type="view" value="OrderByReferrerReport"/>
</request-map>
<request-map uri="OrdersByChannel.pdf"><security https="true" auth="true"/>
<event type="groovy" path="component://birt/groovyScripts/order/OrderByChannel.groovy"/>
<response name="success" type="view" value="OrdersByChannelReport"/>
Expand Down Expand Up @@ -124,7 +121,6 @@ under the License.
<view-map name="SalesOrderReportMonthHTML" type="birt" page="component://birt/webapp/ordermgr/reports/SalesReportMonth.rptdesign" content-type="text/html"/>
<view-map name="NetBeforeOverheadOrderReport" type="birt" page="component://birt/webapp/ordermgr/reports/NetBeforeOverheadReport.rptdesign" content-type="application/pdf"/>
<view-map name="ProductDemandOrderReport" type="birt" page="component://birt/webapp/ordermgr/reports/ProductDemandReport.rptdesign" content-type="application/pdf"/>
<view-map name="OrderByReferrerReport" type="birt" page="component://birt/webapp/ordermgr/reports/OrderByReferrer.rptdesign" content-type="application/pdf"/>
<view-map name="OrdersByChannelReport" type="birt" page="component://birt/webapp/ordermgr/reports/OrdersByChannel.rptdesign" content-type="application/pdf"/>
<view-map name="SaleOrderDiscountCodeReport" type="birt" page="component://birt/webapp/ordermgr/reports/OrderDiscountCodeReport.rptdesign" content-type="application/pdf"/>
<view-map name="Last3MonthsSalesReport" type="birt" page="component://birt/webapp/ordermgr/reports/Last3MonthsSalesReport.rptdesign" content-type="application/pdf"/>
Expand Down

0 comments on commit 782badc

Please sign in to comment.