Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OLINGO-1577] Determine content type from HTTP response #97

Merged
merged 1 commit into from Nov 12, 2022

Conversation

dheid
Copy link
Contributor

@dheid dheid commented Nov 11, 2022

Hi @mibo !

I have an urgend issue with error responses from our SAP instance. The instance sometimes delivers XML answers, but the request was made using "application/json" as an accept header. I found an issue belonging to his: https://issues.apache.org/jira/projects/OLINGO/issues/OLINGO-1577

So I created this fix. It tries to determine the content type from the HTTP response and falls back to the accept header.

Sorry for reordering the imports. My IDE does this automatically on cleanup...

Best regards

Daniel

@dheid dheid changed the title OLINGO-1577 Determine content type from HTTP response [OLINGO-1577] Determine content type from HTTP response Nov 11, 2022
@mibo mibo self-assigned this Nov 12, 2022
@mibo
Copy link
Contributor

mibo commented Nov 12, 2022

Hi @dheid, Thanks for the fix and contribution 👍
Will have a look into (most likely tomorrow).
Kind Regards, Michael

@mibo mibo self-requested a review November 12, 2022 21:32
Copy link
Contributor

@mibo mibo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mibo
Copy link
Contributor

mibo commented Nov 12, 2022

Thanks for the contribution 👍

@mibo mibo merged commit 5327194 into apache:master Nov 12, 2022
@dheid
Copy link
Contributor Author

dheid commented Nov 13, 2022

Do you already know the release date?

@mibo
Copy link
Contributor

mibo commented Nov 13, 2022

No, current plan is to do a release around Christmas.
But I can not promise yet.

@dheid
Copy link
Contributor Author

dheid commented Nov 13, 2022

Is there a way to have a pre-release or beta release plz???

@mibo
Copy link
Contributor

mibo commented Nov 13, 2022

You can use the Apache Snapshot repositories to get the latest snapshot, e.g. odata-parent/4.10.0-SNAPSHOT.

<repository>
  <id>apache.snapshots</id>
  <name>Apache Development Snapshot Repository</name>
  <url>https://repository.apache.org/content/repositories/snapshots/</url>
  <releases>
    <enabled>false</enabled>
  </releases>
  <snapshots>
    <enabled>true</enabled>
  </snapshots>
</repository>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants