This repository has been archived by the owner on Jul 3, 2023. It is now read-only.
[OODT-1012] Add Docker Image creation workflow to maven build process #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR contains the added Dockerfiles for OODT components in radix archetype, and a new build profile named "docker" which activates the docker image creation workflows. It also contains some changes to the properties files and shell scripts, mainly around removing hardcoded URL and file references to streamline containerization, and adding the hardcoded references to the shell scripts so that it won't break existing workflows. It also contains some aesthetic improvements to the log files like whitespace removal. |
|
Quick question, i didn't include the docker-compose.yml file in this PR just yet, mainly because i want to clarify where exactly to put that in the source. The one I have created right now has static image names, and I need to find a way to resolve them dynamically. Any suggestions as to how it should be done? I was thinking to use something like Apache Maven AntRun Plugin to generate the docker-compose.yml file with the correct names. |
IMS94
suggested changes
Jul 21, 2019
mvn/archetypes/radix/src/main/resources/archetype-resources/crawler/Dockerfile
Show resolved
Hide resolved
...dix/src/main/resources/archetype-resources/crawler/src/main/resources/etc/logging.properties
Outdated
Show resolved
Hide resolved
...chetypes/radix/src/main/resources/archetype-resources/filemgr/src/main/resources/bin/filemgr
Outdated
Show resolved
Hide resolved
...chetypes/radix/src/main/resources/archetype-resources/filemgr/src/main/resources/bin/filemgr
Outdated
Show resolved
Hide resolved
...s/radix/src/main/resources/archetype-resources/filemgr/src/main/resources/bin/filemgr-client
Outdated
Show resolved
Hide resolved
...archetypes/radix/src/main/resources/archetype-resources/workflow/src/main/resources/bin/wmgr
Outdated
Show resolved
Hide resolved
...archetypes/radix/src/main/resources/archetype-resources/workflow/src/main/resources/bin/wmgr
Outdated
Show resolved
Hide resolved
...pes/radix/src/main/resources/archetype-resources/workflow/src/main/resources/bin/wmgr-client
Outdated
Show resolved
Hide resolved
...ix/src/main/resources/archetype-resources/workflow/src/main/resources/etc/logging.properties
Outdated
Show resolved
Hide resolved
...x/src/main/resources/archetype-resources/workflow/src/main/resources/etc/workflow.properties
Outdated
Show resolved
Hide resolved
|
@yasithmilinda were you able to look at those review comments? |
yasithdev
force-pushed
the
OODT-1012
branch
2 times, most recently
from
aaf3ab6
to
02e95b2
Compare
yasithdev
commented
Aug 5, 2019
mvn/archetypes/radix/src/main/resources/archetype-resources/solr/Dockerfile
Show resolved
Hide resolved
…to /bin in each container to match with default configuration
…in/filemgr with latest from development branch
…dxPath and org.apache.oodt.cas.filemgr.repositorymgr.dirs back to path reference
…type-resources/filemgr/src/main/resources/policy/oodt/product-types.xml
Upgrade maven-archetype-plugin and archetype-packaging ext to 3.1.1 Remove comment in goal.txt (else throws an error in 3.1.1) move test project in radix-archetype to radix-archetype-test/ folder
update archetype-metadata to use filtering to fill in variables update README.txt with the right OODT version the project was exported
… not found issues) update docker-compose file to use bind mounts on the named volumes (to support working out-of-the-box)
…ronment variables
update dockerfile in resmgr to ResourceManagerMain
…rchetype-metadata to create temp, logs and data directories
…er @ docker-compose.yml
yasithdev
added a commit
to yasithdev/oodt
that referenced
this pull request
Jan 26, 2021
…apache#100) * Add changed files from exported radix build to source * add missing dockerfile-maven-version property to parent pom * revert logging.properties files. update dockerfiles with workdir set to /bin in each container to match with default configuration * update Dockerfile with the same command used in bin/filemgr. update bin/filemgr with latest from development branch * fix bin/filemgr-client startup class * fix scripts wmgr and wmgr-client with code from development branch * update URI reference for org.apache.oodt.cas.filemgr.catalog.lucene.idxPath and org.apache.oodt.cas.filemgr.repositorymgr.dirs back to path reference * fix file path change in mvn/archetypes/radix/src/main/resources/archetype-resources/filemgr/src/main/resources/policy/oodt/product-types.xml * more file path fixes. reverting to state in development branch * update workflow.properties * Updated RADIX build system to use the correct version of OODT Upgrade maven-archetype-plugin and archetype-packaging ext to 3.1.1 Remove comment in goal.txt (else throws an error in 3.1.1) move test project in radix-archetype to radix-archetype-test/ folder * add docker-compose file update archetype-metadata to use filtering to fill in variables update README.txt with the right OODT version the project was exported * add missing docker profile to workflow manager * update oodt references in RADIX build to 1.9-SNAPSHOT (to avoid class not found issues) update docker-compose file to use bind mounts on the named volumes (to support working out-of-the-box) * make RESOURCE_MANAGER_URL_PROPERTY in workflowmanager substitute environment variables * fix issue in crawler start command in dockerfile * change xmlrpc to avrorpc in filemgr.properties - filemgr.server update dockerfile in resmgr to ResourceManagerMain * remove hardcoded volume names in docker-compose.yml * add /Users/yasith/Projects/oodt/oodt to docker-compose file. update archetype-metadata to create temp, logs and data directories * update resource.properties of resmgr. disable restart=always in crawler @ docker-compose.yml * set a default crawl job to the crawler and update its dockerfile * fix typo in crawler Dockerfile
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a step to make OODT deployment and management simple, major OODT components should be containerized during the build process. This allows for simplified deployment of OODT components using technologies like Kubernetes, Docker Compose and Helm.
The dockerfile-maven plugin could be used to add a build execution to the existing RADiX process. This enables users to create docker images through maven build process, which contains their workflows and components.