Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement concurrent MultipartUploadWriter #3915

Merged
merged 6 commits into from
Jan 5, 2024
Merged

feat: implement concurrent MultipartUploadWriter #3915

merged 6 commits into from
Jan 5, 2024

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Jan 4, 2024

Related

#3899

@WenyXu WenyXu mentioned this pull request Jan 4, 2024
Closed
6 tasks
@WenyXu WenyXu force-pushed the feat/concurrent-multipart-upload-writer branch from aec2a10 to 7222f7c Compare January 4, 2024 16:39
@WenyXu WenyXu force-pushed the feat/concurrent-multipart-upload-writer branch from 7222f7c to cd09018 Compare January 4, 2024 16:52
@WenyXu WenyXu marked this pull request as ready for review January 4, 2024 16:58
@WenyXu WenyXu requested a review from Xuanwo as a code owner January 4, 2024 16:58
@WenyXu WenyXu force-pushed the feat/concurrent-multipart-upload-writer branch 4 times, most recently from a09ad76 to 29cf691 Compare January 4, 2024 17:40
@WenyXu WenyXu marked this pull request as draft January 4, 2024 17:49
@WenyXu WenyXu force-pushed the feat/concurrent-multipart-upload-writer branch 5 times, most recently from 9201228 to 6965d9a Compare January 4, 2024 20:14
@WenyXu WenyXu force-pushed the feat/concurrent-multipart-upload-writer branch from 6965d9a to 7004275 Compare January 4, 2024 20:21
@WenyXu WenyXu force-pushed the feat/concurrent-multipart-upload-writer branch from 6e8a178 to 59106c7 Compare January 5, 2024 10:25
@WenyXu WenyXu marked this pull request as ready for review January 5, 2024 10:25
Xuanwo
Xuanwo reviewed Jan 5, 2024
View reviewed changes
core/src/raw/oio/write/multipart_upload_write.rs Outdated Show resolved Hide resolved
core/src/raw/oio/write/multipart_upload_write.rs Outdated Show resolved Hide resolved
core/src/raw/oio/write/multipart_upload_write.rs Outdated Show resolved Hide resolved
core/src/raw/oio/write/multipart_upload_write.rs Outdated Show resolved Hide resolved
core/src/raw/oio/write/multipart_upload_write.rs Outdated Show resolved Hide resolved
core/src/raw/oio/write/multipart_upload_write.rs Outdated Show resolved Hide resolved
core/src/raw/oio/write/multipart_upload_write.rs Outdated Show resolved Hide resolved
core/src/raw/oio/write/multipart_upload_write.rs Outdated Show resolved Hide resolved
core/src/raw/oio/write/multipart_upload_write.rs Outdated Show resolved Hide resolved
@WenyXu WenyXu force-pushed the feat/concurrent-multipart-upload-writer branch from 64ae07f to aacd003 Compare January 5, 2024 11:08
Xuanwo
Xuanwo reviewed Jan 5, 2024
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most LGTM, only a small change needed.

core/src/raw/oio/write/multipart_upload_write.rs Show resolved Hide resolved
Xuanwo
Xuanwo approved these changes Jan 5, 2024
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@Xuanwo Xuanwo merged commit 23db343 into apache:main Jan 5, 2024
191 checks passed
@Zheaoli Zheaoli mentioned this pull request Jan 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

Assignees
No one assigned
Labels
releases-note/feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@WenyXu @Xuanwo