Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Downgrade artifact actions until regression addressed #3935

Merged
merged 2 commits into from
Jan 7, 2024
Merged

ci: Downgrade artifact actions until regression addressed #3935

merged 2 commits into from
Jan 7, 2024

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Jan 7, 2024

@Xuanwo
ci: Downgrade artifact actions until regression addressed
58d2fa1 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo requested a review from PsiACE as a code owner January 7, 2024 02:54
suyanhanx
suyanhanx approved these changes Jan 7, 2024
View reviewed changes
Copy link
Member

@suyanhanx suyanhanx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@suyanhanx
Copy link
Member

May we create an issue to track this?

@Xuanwo
rust setup
af39d5d 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Copy link
Member Author

Xuanwo commented Jan 7, 2024

May we create an issue to track this?

Upstream already has one, and it's unrelated to our users. Perhaps we don't need to create an issue for this?

@suyanhanx
Copy link
Member

Upstream already has one, and it's unrelated to our users. Perhaps we don't need to create an issue for this?

I mean that we can bring this back someday in the future. But it doesn't matter. :-)

@Xuanwo
Copy link
Member Author

Xuanwo commented Jan 7, 2024

I mean that we can bring this back someday in the future. But it doesn't matter. :-)

Maybe in next dependabot upgrade :-)

@Xuanwo Xuanwo merged commit a8ba758 into main Jan 7, 2024
49 checks passed
@Xuanwo Xuanwo deleted the downgrade-actions branch January 7, 2024 03:20
@Zheaoli Zheaoli mentioned this pull request Jan 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suyanhanx suyanhanx suyanhanx approved these changes

@PsiACE PsiACE Awaiting requested review from PsiACE PsiACE is a code owner

@tisonkun tisonkun Awaiting requested review from tisonkun

Assignees
No one assigned
Labels
releases-note/ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Xuanwo @suyanhanx