Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(services/webhdfs): Implement multi write via CONCAT #3939

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

hoslo
Copy link
Contributor

@hoslo hoslo commented Jan 7, 2024

fixed #3924

@hoslo hoslo requested a review from Xuanwo as a code owner January 7, 2024 13:27
@hoslo hoslo force-pushed the support-webhdfs-multi-write branch 2 times, most recently from a65577d to 1ab2c4b Compare January 7, 2024 14:51
@hoslo hoslo force-pushed the support-webhdfs-multi-write branch 3 times, most recently from 3fb60a9 to e646b8e Compare January 9, 2024 08:33
core/src/services/webhdfs/backend.rs Outdated Show resolved Hide resolved
core/src/services/webhdfs/writer.rs Outdated Show resolved Hide resolved
core/src/services/webhdfs/backend.rs Outdated Show resolved Hide resolved
core/src/services/webhdfs/writer.rs Outdated Show resolved Hide resolved
core/src/services/webhdfs/writer.rs Outdated Show resolved Hide resolved
@hoslo hoslo force-pushed the support-webhdfs-multi-write branch 2 times, most recently from ecdf1a2 to fa17eee Compare January 9, 2024 09:00
@hoslo
Copy link
Contributor Author

hoslo commented Jan 9, 2024

I run the behavior test locally and I succeed, what are the reasons for failure in CI?

@Xuanwo
Copy link
Member

Xuanwo commented Jan 9, 2024

I run the behavior test locally and I succeed, what are the reasons for failure in CI?

Write failed for:

  2024-01-09T09:03:45.037494Z  WARN opendal::services: service=webhdfs operation=Writer::close path=3bfb3b38-eb71-4a3d-8699-774887cd431c written=10485760B -> data close failed: NotFound (permanent) at Writer::close, context: { uri: http://127.0.0.1:9870/webhdfs/v1/07b41151-d577-442f-8505-a6fd7bb6063e/3bfb3b38-eb71-4a3d-8699-774887cd431c?op=CONCAT&sources=/07b41151-d577-442f-8505-a6fd7bb6063e/da42e868-6285-4745-a88d-b2dd2d826eb2%2C/07b41151-d577-442f-8505-a6fd7bb6063e/92daa91e-9513-4165-8f8b-0d91fa97175b, response: Parts { status: 404, version: HTTP/1.1, headers: {"date": "Tue, 09 Jan 2024 09:03:45 GMT", "date": "Tue, 09 Jan 2024 09:03:45 GMT", "cache-control": "no-cache", "expires": "Tue, 09 Jan 2024 09:03:45 GMT", "pragma": "no-cache", "x-frame-options": "SAMEORIGIN", "content-type": "application/json", "transfer-encoding": "chunked"} }, service: webhdfs, path: 3bfb3b38-eb71-4a3d-8699-774887cd431c } => WebHdfsError { exception: "FileNotFoundException", message: "File does not exist: /07b41151-d577-442f-8505-a6fd7bb6063e/92daa91e-9513-4165-8f8b-0d91fa97175b", java_class_name: "java.io.FileNotFoundException" }

@hoslo
Copy link
Contributor Author

hoslo commented Jan 9, 2024

I run the behavior test locally and I succeed, what are the reasons for failure in CI?

Write failed for:

  2024-01-09T09:03:45.037494Z  WARN opendal::services: service=webhdfs operation=Writer::close path=3bfb3b38-eb71-4a3d-8699-774887cd431c written=10485760B -> data close failed: NotFound (permanent) at Writer::close, context: { uri: http://127.0.0.1:9870/webhdfs/v1/07b41151-d577-442f-8505-a6fd7bb6063e/3bfb3b38-eb71-4a3d-8699-774887cd431c?op=CONCAT&sources=/07b41151-d577-442f-8505-a6fd7bb6063e/da42e868-6285-4745-a88d-b2dd2d826eb2%2C/07b41151-d577-442f-8505-a6fd7bb6063e/92daa91e-9513-4165-8f8b-0d91fa97175b, response: Parts { status: 404, version: HTTP/1.1, headers: {"date": "Tue, 09 Jan 2024 09:03:45 GMT", "date": "Tue, 09 Jan 2024 09:03:45 GMT", "cache-control": "no-cache", "expires": "Tue, 09 Jan 2024 09:03:45 GMT", "pragma": "no-cache", "x-frame-options": "SAMEORIGIN", "content-type": "application/json", "transfer-encoding": "chunked"} }, service: webhdfs, path: 3bfb3b38-eb71-4a3d-8699-774887cd431c } => WebHdfsError { exception: "FileNotFoundException", message: "File does not exist: /07b41151-d577-442f-8505-a6fd7bb6063e/92daa91e-9513-4165-8f8b-0d91fa97175b", java_class_name: "java.io.FileNotFoundException" }

I encountered this error, but it's not necessarily reproducible. Running the test that failed on its own doesn't show any issues.

@Xuanwo
Copy link
Member

Xuanwo commented Jan 9, 2024

I encountered this error, but it's not necessarily reproducible. Running the test that failed on its own doesn't show any issues.

Seems the error here is not checked? You can fix block_write related staffs in this PR directly.

https://github.com/apache/incubator-opendal/blob/b956b76d5fa02c069516980df4b428c35fa49e49/core/src/raw/oio/write/block_write.rs#L235

@hoslo hoslo force-pushed the support-webhdfs-multi-write branch 2 times, most recently from afd4795 to 4a9ac87 Compare January 9, 2024 10:41
@hoslo
Copy link
Contributor Author

hoslo commented Jan 9, 2024

I encountered this error, but it's not necessarily reproducible. Running the test that failed on its own doesn't show any issues.

Seems the error here is not checked? You can fix block_write related staffs in this PR directly.

https://github.com/apache/incubator-opendal/blob/b956b76d5fa02c069516980df4b428c35fa49e49/core/src/raw/oio/write/block_write.rs#L235

Still have a problem.

@hoslo hoslo force-pushed the support-webhdfs-multi-write branch 2 times, most recently from 94e19f7 to cca2f84 Compare January 10, 2024 01:24
@hoslo
Copy link
Contributor Author

hoslo commented Jan 10, 2024

@Xuanwo The issue is caused by automatic redirection, now you can proceed with the merge.

core/src/services/webhdfs/backend.rs Outdated Show resolved Hide resolved
core/src/services/webhdfs/backend.rs Outdated Show resolved Hide resolved
core/src/services/webhdfs/writer.rs Outdated Show resolved Hide resolved
@hoslo hoslo force-pushed the support-webhdfs-multi-write branch 2 times, most recently from 7e2e064 to 1814dd0 Compare January 10, 2024 03:45
@hoslo hoslo requested a review from PsiACE as a code owner January 10, 2024 03:45
@hoslo hoslo force-pushed the support-webhdfs-multi-write branch 2 times, most recently from 5216f05 to cadf550 Compare January 10, 2024 04:11
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@hoslo hoslo force-pushed the support-webhdfs-multi-write branch 16 times, most recently from dd88098 to d9259cd Compare January 10, 2024 07:08
@hoslo hoslo force-pushed the support-webhdfs-multi-write branch from d9259cd to 56402b4 Compare January 10, 2024 07:12
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for your patience!

@Xuanwo Xuanwo merged commit 8714ad7 into apache:main Jan 10, 2024
187 of 188 checks passed
@hoslo hoslo deleted the support-webhdfs-multi-write branch January 19, 2024 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

services/webhdfs: Implement multi write via CONCAT
2 participants