Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Remove unused dep async-compat #3947

Merged
merged 4 commits into from
Jan 9, 2024
Merged

chore: Remove unused dep async-compat #3947

merged 4 commits into from
Jan 9, 2024

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Jan 9, 2024

Close #3946

@Xuanwo
chore: Remove unused dep async-compat
224a14e 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo requested a review from PsiACE as a code owner January 9, 2024 05:47
@Xuanwo Xuanwo requested review from oowl and suyanhanx January 9, 2024 05:47
suyanhanx
suyanhanx approved these changes Jan 9, 2024
View reviewed changes
Copy link
Member

@suyanhanx suyanhanx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Xuanwo
Fix c cargo.lock
873c26b 
Signed-off-by: Xuanwo <github@xuanwo.io>
xyjixyjixyji
xyjixyjixyji approved these changes Jan 9, 2024
View reviewed changes
Copy link
Contributor

@xyjixyjixyji xyjixyjixyji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Xuanwo
Fix build under wasm32
c6f7f89 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
requires rt
005e84d 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo merged commit 1bc80d7 into main Jan 9, 2024
214 checks passed
@Xuanwo Xuanwo deleted the path-cache branch January 9, 2024 06:17
@Zheaoli Zheaoli mentioned this pull request Jan 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suyanhanx suyanhanx suyanhanx approved these changes

@oowl oowl oowl approved these changes

@xyjixyjixyji xyjixyjixyji xyjixyjixyji approved these changes

@PsiACE PsiACE Awaiting requested review from PsiACE PsiACE is a code owner

Assignees
No one assigned
Labels
releases-note/chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove the depends on async-compat
4 participants
@Xuanwo @suyanhanx @oowl @xyjixyjixyji