Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Update release guide to adapt as a new TLP #4011

Merged
merged 3 commits into from
Jan 18, 2024
Merged

docs: Update release guide to adapt as a new TLP #4011

merged 3 commits into from
Jan 18, 2024

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Jan 18, 2024 •
edited

@Xuanwo
docs: Update release guide to adapt as a new TLP
2085a72 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo requested a review from PsiACE as a code owner January 18, 2024 06:07
@Xuanwo Xuanwo mentioned this pull request Jan 18, 2024
Closed
20 tasks
suyanhanx
suyanhanx approved these changes Jan 18, 2024
View reviewed changes
Copy link
Member

@suyanhanx suyanhanx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@suyanhanx
Copy link
Member

How about updating the release & checking script together?

@Xuanwo
Copy link
Member Author

Xuanwo commented Jan 18, 2024

How about updating the release & checking script together?

Seems no extra update needed.

@suyanhanx
Copy link
Member

https://github.com/apache/incubator-opendal/blob/d0124baed3b1b219e3caedd9575eab55f41e5351/scripts/README.md?plain=1#L19
One line found

@Xuanwo
Update
343dd7b 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Copy link
Member Author

Xuanwo commented Jan 18, 2024

https://github.com/apache/incubator-opendal/blob/d0124baed3b1b219e3caedd9575eab55f41e5351/scripts/README.md?plain=1#L19

One line found

Fixed

Young-Flash
Young-Flash approved these changes Jan 18, 2024
View reviewed changes
Copy link
Member

@Young-Flash Young-Flash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GREAT!!!

PsiACE
PsiACE approved these changes Jan 18, 2024
View reviewed changes
Copy link
Member

@PsiACE PsiACE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 Cool

morristai
morristai approved these changes Jan 18, 2024
View reviewed changes
Copy link
Member

@morristai morristai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Zheaoli
Zheaoli approved these changes Jan 18, 2024
View reviewed changes
Copy link
Member

@Zheaoli Zheaoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I will bump version to 0.44.2 after this PR merged

tisonkun
tisonkun approved these changes Jan 18, 2024
View reviewed changes
Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One minor comment inline.

@tisonkun tisonkun merged commit 33174bd into main Jan 18, 2024
15 checks passed
@tisonkun tisonkun deleted the update-guide branch January 18, 2024 23:40
@Zheaoli Zheaoli mentioned this pull request Jan 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zheaoli Zheaoli Zheaoli approved these changes

@morristai morristai morristai approved these changes

@tisonkun tisonkun tisonkun approved these changes

@suyanhanx suyanhanx suyanhanx approved these changes

@PsiACE PsiACE PsiACE approved these changes

@Young-Flash Young-Flash Young-Flash approved these changes

Assignees
No one assigned
Labels
releases-note/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@Xuanwo @suyanhanx @Zheaoli @morristai @tisonkun @PsiACE @Young-Flash