Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add trademark information to every possible published readme #4014

Merged
merged 2 commits into from
Jan 18, 2024
Merged

docs: add trademark information to every possible published readme #4014

merged 2 commits into from
Jan 18, 2024

Conversation

PsiACE
Copy link
Member

@PsiACE PsiACE commented Jan 18, 2024

  • Add trademark information to every README page that may be published or become an entry point. (bin/bindings/core/repo)
  • Unified format.
## Trademarks & Licenses

Licensed under the Apache License, Version 2.0: http://www.apache.org/licenses/LICENSE-2.0

Apache OpenDAL, OpenDAL, and Apache are either registered trademarks or trademarks of the Apache Software Foundation.

xyjixyjixyji
xyjixyjixyji approved these changes Jan 18, 2024
View reviewed changes
Copy link
Contributor

@xyjixyjixyji xyjixyjixyji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

tisonkun
tisonkun reviewed Jan 18, 2024
View reviewed changes
core/README.md Outdated Show resolved Hide resolved
tisonkun
tisonkun reviewed Jan 18, 2024
View reviewed changes
Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@PsiACE
docs: add trademark information to every possible published readme.
d1a7cd2 
Signed-off-by: Chojan Shang <psiace@apache.org>
@PsiACE
docs: minor update
36c48f2 
Signed-off-by: Chojan Shang <psiace@apache.org>
@suyanhanx
Copy link
Member

It may also be necessary to add a logo statement if the entry uses the logos(such as the OpenDAL logo and Apache feather logo).
May need to check one by one.

Xuanwo
Xuanwo approved these changes Jan 18, 2024
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo merged commit df9697a into apache:main Jan 18, 2024
51 checks passed
@PsiACE PsiACE deleted the bindings-trademark branch January 18, 2024 14:34
@Zheaoli Zheaoli mentioned this pull request Jan 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tisonkun tisonkun tisonkun left review comments

@Xuanwo Xuanwo Xuanwo approved these changes

@xyjixyjixyji xyjixyjixyji xyjixyjixyji approved these changes

@messense messense Awaiting requested review from messense messense is a code owner

@Zheaoli Zheaoli Awaiting requested review from Zheaoli Zheaoli is a code owner

@suyanhanx suyanhanx Awaiting requested review from suyanhanx suyanhanx is a code owner

@oowl oowl Awaiting requested review from oowl oowl is a code owner

@silver-ymz silver-ymz Awaiting requested review from silver-ymz silver-ymz is a code owner

@morristai morristai Awaiting requested review from morristai

Assignees
No one assigned
Labels
releases-note/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@PsiACE @suyanhanx @Xuanwo @tisonkun @xyjixyjixyji