-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: allow building from source #4079
Conversation
Thanks a lot for the change and the try to package oli on nixos. Would you like run cargo check under those packages to make sure cargo.lock generated? |
Or do you want me to help do this? |
Some bindings are not part of the source for tagged releases. They need to be excluded from the main cargo.toml to allow building from source for a release
c11fbf1
to
c69d541
Compare
@Xuanwo done, completely forgot, thank you for reminding me. |
Since those bindings are not workspace members anymore, their cargo.toml and cargo.lock also need to be updated. 👀 |
All CI passed so that's shouldn't be contributors work to update them. Let's update by ourselves. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@Xuanwo thanks a lot for the prompt review and for the help! |
the source released on github doesn't include
several bindings. This removes them from the
Cargo.toml to allow building from source
without this change, building from source results in errors like
to give more context, I'm trying to package oli for nixpkgs, this seems like a very useful tool.
thank you for your work on opendal, this looks amazing!