Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: allow building from source #4079

Merged
merged 1 commit into from
Jan 27, 2024
Merged

Conversation

happysalada
Copy link
Contributor

the source released on github doesn't include
several bindings. This removes them from the
Cargo.toml to allow building from source

without this change, building from source results in errors like

 > error: failed to load manifest for workspace member `/private/tmp/nix-build-oli-0.44.2.drv-0/source/bindings/haskell`
       >
       > Caused by:
       >   failed to read `/private/tmp/nix-build-oli-0.44.2.drv-0/source/bindings/haskell/Cargo.toml`
       >

to give more context, I'm trying to package oli for nixpkgs, this seems like a very useful tool.

thank you for your work on opendal, this looks amazing!

@Xuanwo
Copy link
Member

Xuanwo commented Jan 27, 2024

Thanks a lot for the change and the try to package oli on nixos. Would you like run cargo check under those packages to make sure cargo.lock generated?

@Xuanwo
Copy link
Member

Xuanwo commented Jan 27, 2024

Or do you want me to help do this?

Some bindings are not part of the source for
tagged releases. They need to be excluded from
the main cargo.toml to allow building from
source for a release
@happysalada
Copy link
Contributor Author

@Xuanwo done, completely forgot, thank you for reminding me.
Thank you for the quick review! Let me know if anything!

@suyanhanx
Copy link
Member

suyanhanx commented Jan 27, 2024

Since those bindings are not workspace members anymore, their cargo.toml and cargo.lock also need to be updated. 👀
But this is also quite troublesome. If you want me to handle it that's fine.

@Xuanwo
Copy link
Member

Xuanwo commented Jan 27, 2024

All CI passed so that's shouldn't be contributors work to update them. Let's update by ourselves.

Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo merged commit 47dc9b6 into apache:main Jan 27, 2024
22 checks passed
@happysalada happysalada deleted the fix_cargo_toml branch January 27, 2024 18:10
@happysalada
Copy link
Contributor Author

@Xuanwo thanks a lot for the prompt review and for the help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants