Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: object store adapter based on v0.9 #4233

Merged
merged 3 commits into from
Feb 22, 2024
Merged

feat: object store adapter based on v0.9 #4233

merged 3 commits into from
Feb 22, 2024

Conversation

waynexia
Copy link
Member

Bump the object_store version in object_store_opendal to v0.9

Changed API:

  • put: request file meta in return value
  • put_opts: new API
  • list not an async fn
  • list_with_offset: not an async fn

@waynexia
feat: object store adapter based on v0.9
1d62ac3 
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
waynexia
waynexia commented Feb 21, 2024
View reviewed changes
integrations/object_store/Cargo.toml Show resolved Hide resolved
integrations/object_store/Cargo.toml Show resolved Hide resolved
integrations/object_store/src/lib.rs Outdated Show resolved Hide resolved
integrations/object_store/src/lib.rs Show resolved Hide resolved
PsiACE
PsiACE approved these changes Feb 21, 2024
View reviewed changes
Copy link
Member

@PsiACE PsiACE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@waynexia
return empty put result
877b72a 
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
@Xuanwo Xuanwo merged commit af1433d into apache:main Feb 22, 2024
2 checks passed
@waynexia waynexia deleted the bump-object-store branch February 22, 2024 06:51
@Xuanwo Xuanwo mentioned this pull request Feb 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PsiACE PsiACE PsiACE approved these changes

@Xuanwo Xuanwo Awaiting requested review from Xuanwo Xuanwo is a code owner

@xyjixyjixyji xyjixyjixyji Awaiting requested review from xyjixyjixyji

@morristai morristai Awaiting requested review from morristai

Assignees
No one assigned
Labels
releases-note/feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@waynexia @Xuanwo @PsiACE