-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(services/aliyun-drive): support AliyunDrive #4585
Conversation
b5051c3
to
0daa9ad
Compare
436be21
to
0d21c92
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot! Only some small changes.
Done. Sure, I'll fix them later today. |
0d21c92
to
cdb6bf9
Compare
f64a877
to
7972760
Compare
7972760
to
1a71b2a
Compare
Hi, it's not a requirement to implement |
Well. that's fine. I will raise another PR to improve it. Let's make it work at first. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
1a71b2a
to
b07d083
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, bravo work!
Great work! Thank you! |
I'll set up the test credentials for this service. |
thank you! |
feat(services/aliyun-drive): add support for AliyunDrive
Closing #3415. Ready for review.
API documentation reference: https://www.yuque.com/aliyundrive/zpfszx/gogo34oi2gy98w5d
Required Environment Variables:
To run behavior tests, use the following command:
Note that the test threads should be set to 1 as it may fail part of the test due to rate limit.
AliyunDrive has a feature called Rapid Upload, but it is difficult to implement completely because the
MultipartWriter
trait design isn't well compatible with this feature at present. Therefore, I have only implemented it on thewrite_once
method.Let's discuss proposing a new
RapiduploadWriter
for this kind of rapid-upload featured service together in the future if you would.