-
Notifications
You must be signed in to change notification settings - Fork 425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC-4638: Executor #4638
RFC-4638: Executor #4638
Conversation
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Thanks for proposing the RFC. This is very useful to our use case. I have two questions:
|
Yes. Failed task will be re-created and re-executed.
Sadly, timeout layer can't control the task managed by executor. One possible workaround is users wrap the future with their own timeout. I'm still working on better solutions. |
Aha, I got an idea of how to fix it. TimeoutLayer will inject the timeout directly into the |
cc @tisonkun, would you like to take a review of this RFC? |
@Xuanwo OK. I'll review this today. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I suggest you to take a look at async-executor's design and see if we can reuse the abstraction at some level.
There is also executor-trait that can be helpful.
Co-authored-by: tison <wander4096@gmail.com>
Signed-off-by: Xuanwo <github@xuanwo.io>
LGTM. |
* feat: Executor Signed-off-by: Xuanwo <github@xuanwo.io> * Update Signed-off-by: Xuanwo <github@xuanwo.io> * Fix spelling Signed-off-by: Xuanwo <github@xuanwo.io> * Update tracking issues Signed-off-by: Xuanwo <github@xuanwo.io> * Update 4638_executor.md Co-authored-by: tison <wander4096@gmail.com> * Polish code example Signed-off-by: Xuanwo <github@xuanwo.io> * Fix typo Signed-off-by: Xuanwo <github@xuanwo.io> --------- Signed-off-by: Xuanwo <github@xuanwo.io> Co-authored-by: tison <wander4096@gmail.com>
Add executor in opendal to allow running tasks concurrently in background.