Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC and implementations for limited reader #90

Merged
merged 7 commits into from
Mar 2, 2022
Merged

RFC and implementations for limited reader #90

merged 7 commits into from
Mar 2, 2022

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Mar 2, 2022

Signed-off-by: Xuanwo github@xuanwo.io

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Fix #86

Rendered RFC: https://github.com/datafuselabs/opendal/blob/fix-reader/docs/rfcs/0090-limited-reader.md

Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Copy link
Member Author

Xuanwo commented Mar 2, 2022

Oh, the size should take offset into consideration, let me fix it and add a test.

src/io.rs Outdated Show resolved Hide resolved
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Copy link
Member Author

Xuanwo commented Mar 2, 2022

Ping @dantengsky @zhang2014 @sundy-li, I refactor this PR, please read RFC limited-reader for more details.

Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo changed the title io: Fix OpRead's size not set to avoid extra data been read RFC and implementations for limited reader Mar 2, 2022
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Copy link

@dantengsky dantengsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's merge

@dantengsky dantengsky merged commit 619844a into main Mar 2, 2022
@dantengsky dantengsky deleted the fix-reader branch March 2, 2022 10:45
@BohuTANG
Copy link

BohuTANG commented Mar 2, 2022

Cool, I will bump the latest version in this PR:
datafuselabs/databend#4277

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improvement: Avoid reading unnecessary data
5 participants