OPENMEETINGS-2245 Add some warning if mediaDevices is undefined #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solomax
reviewed
Apr 9, 2020
openmeetings-web/src/main/java/org/apache/openmeetings/web/room/raw-settings.js
Outdated
Show resolved
Hide resolved
solomax
reviewed
Apr 9, 2020
openmeetings-web/src/main/java/org/apache/openmeetings/web/room/raw-settings.js
Show resolved
Hide resolved
…' of github.com:apache/openmeetings into feature/openmeetings-2245-mediadevice-chrome-https-only
solomax
reviewed
Apr 9, 2020
openmeetings-web/src/main/java/org/apache/openmeetings/web/app/Application_de.properties.xml
Outdated
Show resolved
Hide resolved
sebawagner
commented
Apr 9, 2020
openmeetings-web/src/main/java/org/apache/openmeetings/web/app/Application_de.properties.xml
Outdated
Show resolved
Hide resolved
added 2 commits
April 10, 2020 11:53
solomax
approved these changes
Apr 9, 2020
|
@sebawagner could you drop merged branches? |
sebawagner
deleted the
feature/openmeetings-2245-mediadevice-chrome-https-only
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is adding a warning.
See Jira for reason, but in chrome over http mediaDevice is simply undefined. And it won't prompt for camera access. You also not able to overwrite or change those settings. The catch block in the current code won't work.
Although its arguable. Its simply that http has very little use for a brower based application that tries to access camera/microphone or other webRTC features.
But I guess above at least has some defined error than just the Javascript to bail.