Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OPENMEETINGS-2339 Fix issue around icons hidden behind drag for video pod #86

Merged
merged 1 commit into from
May 16, 2020
Merged

OPENMEETINGS-2339 Fix issue around icons hidden behind drag for video pod #86

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion openmeetings-web/src/main/java/org/apache/openmeetings/web/room/raw-video.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,7 @@ var Video = (function() {
});
}
v.parent().find('.ui-dialog-titlebar-close').remove();
v.parent().find('.ui-dialog-titlebar').append(OmUtil.tmpl('#video-button-bar'));
v.parent().append(OmUtil.tmpl('#video-button-bar'));
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move icons one level on top of the ui-dialog-titlebar. ui-dialog-titlebar is the element jquery-ui makes dragable.
Like this it looks exactly the same but doesn't have the issue, so that on Mobile you can still click the icons AND drag the dialog.

const refresh = v.parent().find('.btn-refresh')
, tgl = v.parent().find('.btn-toggle')
, cls = v.parent().find('.btn-wclose');
Expand Down
4 changes: 2 additions & 2 deletions openmeetings-web/src/main/webapp/css/raw-room.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -425,11 +425,11 @@ html[dir="rtl"] .room-block .sb-wb .sidebar {
.user-video .ui-dialog-titlebar
, .sharer .ui-dialog-titlebar
, .wb-tool-settings .ui-dialog-titlebar
, .user-video .ui-dialog-titlebar .buttonpane
{
background-color: var(--white);
}
.user-video .ui-dialog-titlebar .buttonpane {
.user-video .buttonpane {
background-color: var(--white);
position: absolute;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sebawagner unfortunately this will NOT work :(
dialog has position: absolute so positioning of this buttonpane is not honored

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed that before, let me have a look. It worked in chrome.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It did work for me on Chrome.
I think there is some CSS missing that I did accidentally not commit. I think some top: 20px somewhere is missing.

right: 2px;
top: 2px
Expand Down