Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPENNLP-999: Use JBake for website (thanks to @wcolen), new layout, and logo #182

Closed
wants to merge 1 commit into from

Conversation

kinow
Copy link
Member

@kinow kinow commented Apr 23, 2017

Thank you for contributing to Apache OpenNLP.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • [ x ] Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • [ x ] Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • [ x ] Has your PR been rebased against the latest commit within the target branch (typically master)?

  • [ x ] Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn clean install at the root opennlp folder?
  • Have you written or updated unit tests to verify your changes?
  • [ x ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file in opennlp folder?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found in opennlp folder?

For documentation related changes:

  • [ x ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

@jzonthemtn
Copy link
Contributor

It looks nice!

opennlp-website

* Suneel Marthi (smarthi) (C-P)
* Daniel Russ (druss) ( C )
* Peter Thygesen (thygesen) ( C )
* Koji Sekiguchi (koji) ( C )
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also add Jeffrey Zemerick (jzemerick) (C) to this list

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, also forgot to add myself....

* Chris Mattmann (mattmann) ( C )
* Anastasija Mensikova (anastasijam) ( C )
* Suneel Marthi (smarthi) (C-P)
* Daniel Russ (druss) ( C )
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Daniel Russ is now C-P

@kottmann
Copy link
Member

All those files should probably have AL headers when possible.

@kinow
Copy link
Member Author

kinow commented Apr 28, 2017

Pull request updated and squashed.

Team members list updated.

Added headers to most files, except for assets (JQuery JS, CSS files, etc). Comments for AsciiDoc are /// and for FreeMaker are like HTML but start with <#--. These comments do not generate extra blank lines when consumed by the template parser.

Also updated the News article page that was not displaying correctly, and removed news/index.html that was never used (templates/news.ftl gets served instead).

Thanks!
Bruno

@kinow
Copy link
Member Author

kinow commented Apr 30, 2017

Gitpubsub for websites allows static content sites being served from a branch, asf-site by default [1]. We could merge
pull request #182, then have a build job in Jenkins, with the following Maven build step:

# build just the web site module
mvn clean package -pl opennlp-site -am

# given using something like ghp-import could be complicated [2]

git add -A -f opennlp-site/target/opennlp-site/
git commit -m "Update site"
git subtree split --prefix opennlp-site/target/opennlp-site/ -b asf-site
git push -f origin asf-site:asf-site

Trigger the job whenever someone commits to opennlp-site (don't remember the names in Jenkins, but you can filter the commit...). That way that branch would always be up to date. I believe this would not automatically reflect opennlp.apache.org. But instead, gitpubsub would push the site to opennlp.staging.apache.org (not sure though).

[1] https://blogs.apache.org/infra/entry/git_based_websites_available
[2] https://github.com/davisp/ghp-import/blob/master/ghp_import.py

@kinow kinow closed this May 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants