OPENNLP-1051: Adds BreakIterator token and sent detector. #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarthi
reviewed
May 7, 2017
| @Override | ||
| public Span[] tokenizePos(String d) { | ||
|
|
||
| List<Span> tokens = new ArrayList<Span>(); |
There was a problem hiding this comment.
Gotcha. I will update.
|
+1 lgtm |
smarthi
reviewed
May 7, 2017
| import opennlp.tools.util.Span; | ||
|
|
||
| /** | ||
| * An implementation of {@link SentenceDetector} that users |
|
Changes Unknown when pulling 278ee11 on jzonthemtn:OPENNLP-1051 into ** on apache:master**. |
kottmann
reviewed
May 7, 2017
| private BreakIterator breakIterator; | ||
|
|
||
| public BreakIteratorSentenceDetector(Locale locale) { | ||
| breakIterator = BreakIterator.getSentenceInstance(Locale.US); |
There was a problem hiding this comment.
When the local is supplied that one should be used, no?
There was a problem hiding this comment.
Yes, absolutely. Thanks for catching that.
smarthi
reviewed
May 7, 2017
| public BreakIteratorTokenizer(Locale locale) { | ||
| breakIterator = BreakIterator.getWordInstance(locale); | ||
| } | ||
|
|
There was a problem hiding this comment.
Would it make sense to add a no-args constructor that defaults to LOCALE_US ???
There was a problem hiding this comment.
I don't have a problem with adding it. Maybe Locale.ENGLISH?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Apache OpenNLP.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically master)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.