#OPENNLP-1199 Correct Loop Bounds for NgramGenerator.generate function #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 lgtm |
|
Thank you for the PR. This needs to be squashed so that there is only one comment in the commit. Also, Please create a JIRA ticket (http://opennlp.apache.org > Development > click on create a JIRA issue hyperlink). Then change the name of the PR something a little for informative like "#XXX correct loop bounds" where XXX is the JIRA issue number. Of course, you don't need to use exactly "correct loop bounds". |
PrachiPrakash
force-pushed
the
NGramGeneratorEnhance
branch
from
24499b2
to
ce23f66
Compare
PrachiPrakash
changed the title
|
@danielruss squashed the previous commits into one and also created a JIRA issue. Can you please verify. |
|
@PrachiPrakash Thanks for the PR! Does this impact any existing unit tests? |
|
@jzonthemtn No, it doesn't impact any existing unit test |
|
Commit message is not in the usual format, we can change it by using "Squash and merge". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small Improvement to NGramGenerators generate function which saves one if comparision