OPENNLP-856: Refactoring AdaptiveFeatureGenerator and FeatureGeneratorAdapter #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
git-svn-id: https://svn.apache.org/repos/asf/opennlp/trunk@1576093 13f79535-47bb-0310-9956-ffa450edef68
EntitylinkerFactory now throws IOException, therefore EntityLinker#init also throws IOException. git-svn-id: https://svn.apache.org/repos/asf/opennlp/trunk@1576275 13f79535-47bb-0310-9956-ffa450edef68
Added method to EntityLinkerFactory takes only EntityLinkerProperties git-svn-id: https://svn.apache.org/repos/asf/opennlp/trunk@1576279 13f79535-47bb-0310-9956-ffa450edef68
Added method to EntityLinkerFactory takes only EntityLinkerProperties git-svn-id: https://svn.apache.org/repos/asf/opennlp/trunk@1576688 13f79535-47bb-0310-9956-ffa450edef68
…re generator configuration. git-svn-id: https://svn.apache.org/repos/asf/opennlp/trunk@1576692 13f79535-47bb-0310-9956-ffa450edef68
…ly and returns instantiated Artifact Serializers instead. git-svn-id: https://svn.apache.org/repos/asf/opennlp/trunk@1576746 13f79535-47bb-0310-9956-ffa450edef68
…to Rodrigo Agerri for providing a patch. git-svn-id: https://svn.apache.org/repos/asf/opennlp/trunk@1576767 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/opennlp/trunk@1577178 13f79535-47bb-0310-9956-ffa450edef68
…entations git-svn-id: https://svn.apache.org/repos/asf/opennlp/trunk@1579910 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/opennlp/trunk@1580107 13f79535-47bb-0310-9956-ffa450edef68
…e deprecated function. git-svn-id: https://svn.apache.org/repos/asf/opennlp/trunk@1580108 13f79535-47bb-0310-9956-ffa450edef68
…he deprecated functions. git-svn-id: https://svn.apache.org/repos/asf/opennlp/trunk@1580109 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/opennlp/trunk@1580111 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/opennlp/trunk@1580112 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/opennlp/trunk@1580113 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/opennlp/trunk@1580116 13f79535-47bb-0310-9956-ffa450edef68
…aced a @params tag with a @return tag. git-svn-id: https://svn.apache.org/repos/asf/opennlp/trunk@1580117 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/opennlp/trunk@1580119 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/opennlp/trunk@1580120 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/opennlp/trunk@1580121 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/opennlp/trunk@1580122 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/opennlp/trunk@1580124 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/opennlp/trunk@1580125 13f79535-47bb-0310-9956-ffa450edef68
…ger exists? git-svn-id: https://svn.apache.org/repos/asf/opennlp/trunk@1580126 13f79535-47bb-0310-9956-ffa450edef68
…unction as a throw-ed error. git-svn-id: https://svn.apache.org/repos/asf/opennlp/trunk@1580131 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/opennlp/trunk@1580133 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/opennlp/trunk@1580134 13f79535-47bb-0310-9956-ffa450edef68
…to generate the lists. git-svn-id: https://svn.apache.org/repos/asf/opennlp/trunk@1580137 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/opennlp/trunk@1580138 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/opennlp/trunk@1580139 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/opennlp/trunk@1709574 13f79535-47bb-0310-9956-ffa450edef68
…ng included in the model. git-svn-id: https://svn.apache.org/repos/asf/opennlp/trunk@1712553 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/opennlp/trunk@1712561 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/opennlp/trunk@1712791 13f79535-47bb-0310-9956-ffa450edef68
… enabled via settings git-svn-id: https://svn.apache.org/repos/asf/opennlp/trunk@1723671 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/opennlp/trunk@1725068 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/opennlp/trunk@1725190 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/opennlp/trunk@1729193 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/opennlp/trunk@1729194 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/opennlp/trunk@1731084 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/opennlp/trunk@1731145 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/opennlp/trunk@1731148 13f79535-47bb-0310-9956-ffa450edef68
… interface git-svn-id: https://svn.apache.org/repos/asf/opennlp/trunk@1731151 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/opennlp/trunk@1734199 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/opennlp/trunk@1734210 13f79535-47bb-0310-9956-ffa450edef68
…when train data is not sufficient git-svn-id: https://svn.apache.org/repos/asf/opennlp/trunk@1734886 13f79535-47bb-0310-9956-ffa450edef68
The class SequenceStreamEventStream has a few bugs. (1) It truncates the stream early if any sequence is empty. (2) After reset, it will emit the remaining elements from the underlying sequence that was being iterated over before the reset, and then start over from the beginning. (3) It leaks memory by not discarding references to objects it doesn't need anymore. Thanks to Steven Taschuk for providing a patch. git-svn-id: https://svn.apache.org/repos/asf/opennlp/trunk@1741161 13f79535-47bb-0310-9956-ffa450edef68
The train methods should not be possible to use anymore by client code. Some of the methods allow training models which can't be instantiated afterwards. git-svn-id: https://svn.apache.org/repos/asf/opennlp/trunk@1741167 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/opennlp/trunk@1741267 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/opennlp/trunk@1741478 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/opennlp/trunk@1741643 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/opennlp/trunk@1744905 13f79535-47bb-0310-9956-ffa450edef68
All InputStreams are now using the try-with-resources statement and some streams are now also closed correctly. git-svn-id: https://svn.apache.org/repos/asf/opennlp/trunk@1744917 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/opennlp/trunk@1745401 13f79535-47bb-0310-9956-ffa450edef68
…rAdapter. Setting Java compiler version to 1.8.
kinow
pushed a commit
to kinow/opennlp
that referenced
this pull request
May 14, 2017
This closes apache#4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring
AdaptiveFeatureGeneratorandFeatureGeneratorAdapterto only need one (FeatureGeneratorAdapter). Setting Java compiler version to 1.8 to support the default functions inAdaptiveFeatureGeneratorfor backward compatibility.