Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPENNLP-1351: Add ONNX model support for doccat and namefinder #400

Merged
merged 38 commits into from Feb 17, 2022

Conversation

jzonthemtn
Copy link
Contributor

@jzonthemtn jzonthemtn commented Jan 3, 2022

Thank you for contributing to Apache OpenNLP.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
  • Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
  • Has your PR been rebased against the latest commit within the target branch (typically master)?
  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn clean install at the root opennlp folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file in opennlp folder?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found in opennlp folder?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

@jzonthemtn
Copy link
Contributor Author

jzonthemtn commented Jan 3, 2022

There are some checkstyle issues I will be fixing.

Copy link
Member

@kinow kinow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great @jzonthemtn ! Added a few comments, feel free to ignore the ones about stream/newlines/etc. There's one issue in a pom.xml, with a duplicated entry for opennlp-tools. But after fixing that, and ignoring checkstyle with mvn clean test -Dcheckstyle.skip the build passes OK.

👍 🎉

NOTICE Outdated Show resolved Hide resolved
opennlp-dl/README.md Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
opennlp-dl/src/main/java/opennlp/dl/Tokens.java Outdated Show resolved Hide resolved
opennlp-dl/pom.xml Outdated Show resolved Hide resolved
Copy link
Member

@kinow kinow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving one comment on the XML that I think the IDE changed. But other than that, it looks like a good start, then we can refine later if needed 👏

Thanks Jeff!

@jzonthemtn
Copy link
Contributor Author

@kinow I missed that pom file! I fixed it in the last push and added a few more unit tests.

@jzonthemtn jzonthemtn merged commit ba2fdcc into apache:master Feb 17, 2022
@jzonthemtn jzonthemtn deleted the OPENNLP-1351 branch April 10, 2022 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants