New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OPENNLP-1351: Add ONNX model support for doccat and namefinder #400
Conversation
There are some checkstyle issues I will be fixing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great @jzonthemtn ! Added a few comments, feel free to ignore the ones about stream/newlines/etc. There's one issue in a pom.xml
, with a duplicated entry for opennlp-tools
. But after fixing that, and ignoring checkstyle with mvn clean test -Dcheckstyle.skip
the build passes OK.
👍 🎉
opennlp-tools/src/main/java/opennlp/tools/tokenize/WordpieceTokenizer.java
Outdated
Show resolved
Hide resolved
opennlp-dl/src/main/java/opennlp/dl/namefinder/NameFinderDL.java
Outdated
Show resolved
Hide resolved
opennlp-dl/src/main/java/opennlp/dl/namefinder/NameFinderDL.java
Outdated
Show resolved
Hide resolved
opennlp-dl/src/main/java/opennlp/dl/doccat/DocumentCategorizerDL.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leaving one comment on the XML that I think the IDE changed. But other than that, it looks like a good start, then we can refine later if needed 👏
Thanks Jeff!
@kinow I missed that pom file! I fixed it in the last push and added a few more unit tests. |
Thank you for contributing to Apache OpenNLP.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.