Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPENNLP-137 - Training cmd line tools should measure total training time #44

Closed
wants to merge 3 commits into from

Conversation

thygesen
Copy link
Contributor

I have added execute time to the CLI Command Line class. Kept it very simple. hope you like it.
/Peter

@kottmann
Copy link
Member

Commit message should be:
OPENNLP-137: Add execution time to CLI command line

  • Start with jira#
  • Follow git convention and write in imperative

Please update the commit message (e.g. git commit --amend, and then git push -f)

@smarthi
Copy link
Member

smarthi commented Jan 10, 2017

+1 to merge

@asfgit asfgit closed this in 8bba180 Jan 11, 2017
@kottmann
Copy link
Member

Your update didn't go well, the trick is to use force push and not merge any changes from your remote into your local branch.

Anyway, I merged it now. If you want to give it another shot try to get the commits here right, there should only be a single commit in your remote branch.

@thygesen
Copy link
Contributor Author

thygesen commented Jan 11, 2017 via email

asfgit pushed a commit that referenced this pull request Apr 16, 2017
asfgit pushed a commit that referenced this pull request Apr 20, 2017
@giorgio79
Copy link

Uhmm, how can this be optional? Execution time is now returned with regular output... Not good.

@kottmann
Copy link
Member

Right, it should print to System.err, do you want to open a jira and send a PR to fix it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants