OPENNLP-719: Override any name type with specified type #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kottmann
reviewed
Jan 11, 2017
| @@ -143,10 +143,8 @@ public NameFinderEventStream(ObjectStream<NameSample> dataStream) { | |||
| private void overrideDefaultType(Span[] names) { | |||
There was a problem hiding this comment.
We probably want to rename the method.
|
@wcolen your commit message is too long and should start with capital letter, and "Change" doesn't say anything anyway e.g. OPENNLP-719: Override any name type with specified type |
wcolen
changed the title
asfgit
pushed a commit
that referenced
this pull request
Apr 16, 2017
asfgit
pushed a commit
that referenced
this pull request
Apr 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous PR was only overriding if the span type was null, now it override if the parameter is set.
See OPENNLP-719