OPENNLP-887: Replace the Cache class with a LinkedHashMap #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kottmann
reviewed
Dec 19, 2016
| for (int c = 0; c < scores.length; c++) { | ||
| temp_scores[c] = scores[c]; | ||
| } | ||
| System.arraycopy(scores, 0, temp_scores, 0, scores.length); |
There was a problem hiding this comment.
We did reject this change in the past, but now this seems to run just as fast as the for loop.
+1 to keep this
kottmann
reviewed
Dec 19, 2016
| @@ -33,7 +33,7 @@ | |||
| * outcomes, all of which sum to 1. | |||
| * | |||
| **/ | |||
| public double[] eval(String[] context); | |||
| double[] eval(String[] context); | |||
There was a problem hiding this comment.
This file should not be changed with the commit. There are many cases where we have a redundant public modifier. If there is a desire to change that, it would be best to use a re-factoring tool and do this once for the entire code base.
kinow
added a commit
to kinow/opennlp
that referenced
this pull request
May 14, 2017
This closes apache#9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.