Skip to content

Commit

Permalink
Add support for the new XLSX date type in cells, denoted with attribu…
Browse files Browse the repository at this point in the history
…te t="d",

used by Excel 2010.

Also refactor the code so the datetime attribute in pivot tables is also parsed
by the same function, and increase the parsing accuracy to the maximum (HundredthSeconds,
instead of just Seconds).

Fixes: #127034 - xlsx file: imported DateTime cells are empty (Excel 2010 compatible)
Patch by: me

(cherry picked from commit 9621e55)
  • Loading branch information
DamjanJovanovic authored and Pilot-Pirx committed Jan 8, 2023
1 parent a60f0fb commit f42644c
Show file tree
Hide file tree
Showing 6 changed files with 104 additions and 12 deletions.
1 change: 1 addition & 0 deletions main/oox/Library_oox.mk
Expand Up @@ -183,6 +183,7 @@ $(eval $(call gb_Library_add_exception_objects,oox,\
oox/source/helper/binaryoutputstream \
oox/source/helper/binarystreambase \
oox/source/helper/containerhelper \
oox/source/helper/datetimehelper \
oox/source/helper/graphichelper \
oox/source/helper/modelobjecthelper \
oox/source/helper/progressbar \
Expand Down
34 changes: 34 additions & 0 deletions main/oox/inc/oox/helper/datetimehelper.hxx
@@ -0,0 +1,34 @@
/**************************************************************
*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*
*************************************************************/

#ifndef OOX_HELPER_DATETIMEHELPER_HXX
#define OOX_HELPER_DATETIMEHELPER_HXX

#include <com/sun/star/util/DateTime.hpp>
#include "oox/helper/helper.hxx"

namespace oox {

bool parseISO8601DateTime( ::rtl::OUString &aValue, ::com::sun::star::util::DateTime &dateTime );

} // namespace oox

#endif /* OOX_HELPER_DATETIMEHELPER_HXX */
13 changes: 2 additions & 11 deletions main/oox/source/helper/attributelist.cxx
Expand Up @@ -22,6 +22,7 @@


#include "oox/helper/attributelist.hxx"
#include "oox/helper/datetimehelper.hxx"

#include <osl/diagnose.h>
#include <rtl/ustrbuf.hxx>
Expand Down Expand Up @@ -233,17 +234,7 @@ OptValue< DateTime > AttributeList::getDateTime( sal_Int32 nAttrToken ) const
{
OUString aValue = mxAttribs->getOptionalValue( nAttrToken );
DateTime aDateTime;
bool bValid = (aValue.getLength() == 19) && (aValue[ 4 ] == '-') && (aValue[ 7 ] == '-') &&
(aValue[ 10 ] == 'T') && (aValue[ 13 ] == ':') && (aValue[ 16 ] == ':');
if( bValid )
{
aDateTime.Year = static_cast< sal_uInt16 >( aValue.copy( 0, 4 ).toInt32() );
aDateTime.Month = static_cast< sal_uInt16 >( aValue.copy( 5, 2 ).toInt32() );
aDateTime.Day = static_cast< sal_uInt16 >( aValue.copy( 8, 2 ).toInt32() );
aDateTime.Hours = static_cast< sal_uInt16 >( aValue.copy( 11, 2 ).toInt32() );
aDateTime.Minutes = static_cast< sal_uInt16 >( aValue.copy( 14, 2 ).toInt32() );
aDateTime.Seconds = static_cast< sal_uInt16 >( aValue.copy( 17, 2 ).toInt32() );
}
bool bValid = parseISO8601DateTime( aValue, aDateTime );
return OptValue< DateTime >( bValid, aDateTime );
}

Expand Down
54 changes: 54 additions & 0 deletions main/oox/source/helper/datetimehelper.cxx
@@ -0,0 +1,54 @@
/**************************************************************
*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*
*************************************************************/

#include "oox/helper/datetimehelper.hxx"

namespace oox {

// ============================================================================

using namespace ::com::sun::star::util;

using ::rtl::OUString;

// ============================================================================

bool parseISO8601DateTime( OUString &aValue, DateTime &dateTime )
{
bool bValid = (aValue.getLength() >= 19) && (aValue[ 4 ] == '-') && (aValue[ 7 ] == '-') &&
(aValue[ 10 ] == 'T') && (aValue[ 13 ] == ':') && (aValue[ 16 ] == ':');
if( bValid )
{
dateTime.Year = static_cast< sal_uInt16 >( aValue.copy( 0, 4 ).toInt32() );
dateTime.Month = static_cast< sal_uInt16 >( aValue.copy( 5, 2 ).toInt32() );
dateTime.Day = static_cast< sal_uInt16 >( aValue.copy( 8, 2 ).toInt32() );
dateTime.Hours = static_cast< sal_uInt16 >( aValue.copy( 11, 2 ).toInt32() );
dateTime.Minutes = static_cast< sal_uInt16 >( aValue.copy( 14, 2 ).toInt32() );
double seconds = aValue.copy( 17 ).toDouble();
dateTime.Seconds = static_cast< sal_uInt16 >( floor( seconds ) );
dateTime.HundredthSeconds = static_cast< sal_uInt16 >( round ( 100 * ( seconds - floor( seconds ) ) ) );
}
return bValid;
}

// ============================================================================

} // namespace oox
12 changes: 12 additions & 0 deletions main/oox/source/xls/sheetdatacontext.cxx
Expand Up @@ -27,7 +27,9 @@
#include <com/sun/star/table/XCell.hpp>
#include <com/sun/star/table/XCellRange.hpp>
#include <com/sun/star/text/XText.hpp>
#include <com/sun/star/util/DateTime.hpp>
#include "oox/helper/attributelist.hxx"
#include "oox/helper/datetimehelper.hxx"
#include "oox/helper/propertyset.hxx"
#include "oox/xls/addressconverter.hxx"
#include "oox/xls/biffinputstream.hxx"
Expand All @@ -44,6 +46,7 @@ using namespace ::com::sun::star::sheet;
using namespace ::com::sun::star::table;
using namespace ::com::sun::star::text;
using namespace ::com::sun::star::uno;
using namespace ::com::sun::star::util;

using ::oox::core::ContextHandlerRef;
using ::rtl::OUString;
Expand Down Expand Up @@ -212,6 +215,15 @@ void SheetDataContext::onEndElement()
case XML_n:
mrSheetData.setValueCell( maCellData, maCellValue.toDouble() );
break;
case XML_d:
{
DateTime dateTime;
if ( parseISO8601DateTime( maCellValue, dateTime ) )
mrSheetData.setDateTimeCell( maCellData, dateTime );
else
mrSheetData.setErrorCell( maCellData, maCellValue );
}
break;
case XML_b:
mrSheetData.setBooleanCell( maCellData, maCellValue.toDouble() != 0.0 );
break;
Expand Down
2 changes: 1 addition & 1 deletion main/oox/source/xls/unitconverter.cxx
Expand Up @@ -190,7 +190,7 @@ double UnitConverter::calcSerialFromDateTime( const DateTime& rDateTime ) const
sal_Int32 nDays = lclGetDays( Date( rDateTime.Day, rDateTime.Month, rDateTime.Year ) ) - mnNullDate;
OSL_ENSURE( nDays >= 0, "UnitConverter::calcDateTimeSerial - invalid date" );
OSL_ENSURE( (rDateTime.Hours <= 23) && (rDateTime.Minutes <= 59) && (rDateTime.Seconds <= 59), "UnitConverter::calcDateTimeSerial - invalid time" );
return nDays + rDateTime.Hours / 24.0 + rDateTime.Minutes / 1440.0 + rDateTime.Seconds / 86400.0;
return nDays + rDateTime.Hours / 24.0 + rDateTime.Minutes / 1440.0 + rDateTime.Seconds / 86400.0 + rDateTime.HundredthSeconds / 8640000.0;
}

DateTime UnitConverter::calcDateTimeFromSerial( double fSerial ) const
Expand Down

0 comments on commit f42644c

Please sign in to comment.