misc: fix spelling #184
Merged
misc: fix spelling #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pilot-Pirx
reviewed
Nov 16, 2023
ardovm
requested changes
Nov 16, 2023
jbampton
force-pushed
the
fix-spelling
branch
from
d1c3323
to
0b5393c
Compare
ardovm
approved these changes
Nov 19, 2023
There was a problem hiding this comment.
I would normally be very reluctant to rename methods as we are doing here.
However, these methods do not seem to be called anywhere, so renaming them should not break anything.
We should rather understand why this code is here, given that it is not used.
But let's make one step at a time.
asfgit
pushed a commit
that referenced
this pull request
Nov 19, 2023
(cherry picked from commit 81afc36)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.